mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simona Vetter <simona.vetter@ffwll.ch>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Jessica Zhang <quic_jesszhan@quicinc.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	quic_abhinavk@quicinc.com, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, robdclark@gmail.com
Subject: Re: [PATCH v3 2/2] drm/tests: Add test for drm_atomic_helper_commit_modeset_disables()
Date: Tue, 4 Feb 2025 12:23:30 +0100	[thread overview]
Message-ID: <Z6H4sjDt2ewIiObs@phenom.ffwll.local> (raw)
In-Reply-To: <njx2ogued4bbu3ub5jlnczql3x2dr4i72onhmh35tgxyuf3lek@3liwh4butumk>

On Thu, Dec 12, 2024 at 12:50:35AM +0200, Dmitry Baryshkov wrote:
> On Wed, Dec 11, 2024 at 01:18:43PM -0800, Jessica Zhang wrote:
> > Add a subtest to check that modeset is called when the connector is
> > changed
> > 
> > Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> > ---
> > Changes in v3:
> > - Use BUILD_BUG_ON to check connectors and encoders array sizes (Dmitry)
> > - Renamed functions to be more test-specific (Dmitry)
> > - Added comment description for test (Dmitry)
> > - Return get_modes_fixed() directly within the encoder get_modes
> >   function (Dmitry)
> > - Move drm_connector local variable declaration to top of function
> >   (Dmitry)
> > - Changed drm_test_modeset() to a more descriptive name
> > ---
> >  drivers/gpu/drm/tests/Makefile                |   1 +
> >  drivers/gpu/drm/tests/drm_atomic_state_test.c | 244 ++++++++++++++++++++++++++
> >  2 files changed, 245 insertions(+)
> > 
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Pretty sure this blows up with CONFIG_DEBUG_WW_MUTEX_SLOWPATH enabled.
Seems to generally be an issue with our kms kunit tests, so probably also
something we want to fix in CI.

Plus a pile of work to sort this out I fear :-/
-Sima
-- 
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

  reply	other threads:[~2025-02-04 11:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11 21:18 [PATCH v3 0/2] drm: Allow encoder modeset when connectors are changed Jessica Zhang
2024-12-11 21:18 ` [PATCH v3 1/2] drm: allow encoder mode_set even when connectors change for crtc Jessica Zhang
2024-12-11 21:18 ` [PATCH v3 2/2] drm/tests: Add test for drm_atomic_helper_commit_modeset_disables() Jessica Zhang
2024-12-11 22:50   ` Dmitry Baryshkov
2025-02-04 11:23     ` Simona Vetter [this message]
2024-12-16 11:06 ` [PATCH v3 0/2] drm: Allow encoder modeset when connectors are changed Maxime Ripard
2024-12-16 18:27   ` Abhinav Kumar
2024-12-17 15:02     ` Maxime Ripard
2024-12-20  2:05       ` Dmitry Baryshkov
2025-01-07 21:43         ` Abhinav Kumar
2025-01-07 23:31 ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6H4sjDt2ewIiObs@phenom.ffwll.local \
    --to=simona.vetter@ffwll.ch \
    --cc=airlied@gmail.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_jesszhan@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®