From: Tejun Heo <tj@kernel.org>
To: Imran Khan <imran.f.khan@oracle.com>
Cc: jiangshanlai@gmail.com, haakon.bugge@oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] workqueue: introduce queue_delayed_work_on_offline_safe
Date: Tue, 4 Feb 2025 09:17:59 -1000 [thread overview]
Message-ID: <Z6Jn5wOcFKpSGFW4@slm.duckdns.org> (raw)
In-Reply-To: <20250204113635.298634-1-imran.f.khan@oracle.com>
On Tue, Feb 04, 2025 at 10:36:35PM +1100, Imran Khan wrote:
> Currently users of queue_delayed_work_on, need to ensure
> that specified cpu is and remains online. The failure to
> do so may result in delayed_work getting queued on an
> offlined cpu and hence never getting executed.
>
> The current users of queue_delayed_work_on, seem to ensure
> the above mentioned criteria but for those, unknown amongst
> current users or new users, who can't confirm to this
> we need another interface.
>
> So introduce queue_delayed_work_on_offline_safe, which
> is a wrapper around queue_delayed_work_on to ensure that
> the specified cpu is and remains online.
>
> Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
> Acked-by: Haakon Bugge <haakon.bugge@oracle.com>
So, idk, do we really need this? Can't we just add a debug warning which
triggers when CPU goes down with delayed works queued on it?
Thanks.
--
tejun
next prev parent reply other threads:[~2025-02-04 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 11:36 Imran Khan
2025-02-04 19:17 ` Tejun Heo [this message]
2025-02-05 0:54 ` imran.f.khan
2025-02-06 16:34 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6Jn5wOcFKpSGFW4@slm.duckdns.org \
--to=tj@kernel.org \
--cc=haakon.bugge@oracle.com \
--cc=imran.f.khan@oracle.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®