mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Kazuhiro Hayashi <kazuhiro3.hayashi@toshiba.co.jp>,
	linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
	cip-dev@lists.cip-project.org, tglx@linutronix.de,
	rostedt@goodmis.org, linux-rt-users@vger.kernel.org,
	pavel@denx.de
Subject: Re: [PATCH 4.4 4.9 v1 2/2] mm: slub: allocate_slab() enables IRQ right after scheduler starts
Date: Wed, 5 Feb 2025 13:55:59 +0100	[thread overview]
Message-ID: <Z6Nf32YB/J0LMSPw@duo.ucw.cz> (raw)
In-Reply-To: <20250204081813.7qsvLFsU@linutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]

Hi!

> > An simple option would be to backport the series[3], which is possible
> > and has been verified[4]. However, that series pulls functional
> > changes like SYSTEM_SCHEDULING and adjustments for it,
> > early might_sleep() and smp_processor_id() supports, etc.
> > Therefore, this patch uses an extra (but not mainline) flag
> > "system_scheduling" provided by the prior patch instead of
> > introducing SYSTEM_SCHEDULING, then uses the same condition as
> > newer RT kernels in allocate_slab().
> 
> The proposal looks okay. However the verified upstream version not only
> addresses your issue but also makes smp_processor_id() and might_sleep()
> work in the early phase. I would prefer the upstream solution for those
> two reasons.

So... first, thanks for review. This is mostly my fault, Kazuhiro
Hayashi did full backport, but I asked for minimal version.

AFAICT there's no place for stable-rt to apply this, so we'll just be
taking this to our trees in CIP project. (And I prefer smaller
version. Additional checking is nice for development but not so nice
this late in development cycle).

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2025-02-05 12:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04  0:46 [PATCH 4.4 4.9 v1 0/2] Fix repeated WARNING in unpin_current_cpu() Kazuhiro Hayashi
2025-02-04  0:46 ` [PATCH 4.4 4.9 v1 1/2] init: Introduce system_scheduling flag for allocate_slab() Kazuhiro Hayashi
2025-02-04  0:46 ` [PATCH 4.4 4.9 v1 2/2] mm: slub: allocate_slab() enables IRQ right after scheduler starts Kazuhiro Hayashi
2025-02-04  8:18   ` Sebastian Andrzej Siewior
2025-02-05 12:55     ` Pavel Machek [this message]
2025-02-10  7:20     ` kazuhiro3.hayashi
2025-02-10 10:18       ` Sebastian Andrzej Siewior
2025-02-12  7:57         ` kazuhiro3.hayashi
2025-05-02 10:19 ` [PATCH 4.4 4.9 v1 0/2] Fix repeated WARNING in unpin_current_cpu() Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6Nf32YB/J0LMSPw@duo.ucw.cz \
    --to=pavel@denx.de \
    --cc=bigeasy@linutronix.de \
    --cc=cip-dev@lists.cip-project.org \
    --cc=kazuhiro3.hayashi@toshiba.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®