From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ofir Bitton <obitton@habana.ai>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Oded Gabbay <ogabbay@kernel.org>
Subject: Re: [PATCH v1 1/1] accel/habanalabs: Switch to use %ptTs
Date: Thu, 6 Feb 2025 21:13:55 +0200 [thread overview]
Message-ID: <Z6UJ87h0QZ0HHmui@smile.fi.intel.com> (raw)
In-Reply-To: <20250206154855.1125731-1-andriy.shevchenko@linux.intel.com>
On Thu, Feb 06, 2025 at 05:48:55PM +0200, Andy Shevchenko wrote:
> Use %ptTs instead of open-coded variant to print contents of time64_t type
> in human readable form.
...
> dev_err(hdev->dev,
> - "EQ: {CI %u, HB counter %u, last HB time: %s}, PQ: {PI: %u, CI: %u (%u), last HB time: %s}\n",
> + "EQ: {CI %u, HB counter %u, last HB time: %ptTs}, PQ: {PI: %u, CI: %u (%u), last HB time: %ptTs}\n",
> hdev->event_queue.ci,
> heartbeat_debug_info->heartbeat_event_counter,
> - eq_time_str,
> + hdev->heartbeat_debug_info.last_eq_heartbeat_ts,
This has to be a pointer...
> hdev->kernel_queues[cpu_q_id].pi,
> atomic_read(&hdev->kernel_queues[cpu_q_id].ci),
> atomic_read(&hdev->kernel_queues[cpu_q_id].ci) & pq_pi_mask,
> - pq_time_str);
> + hdev->heartbeat_debug_info.last_pq_heartbeat_ts);
...and this.
I will fix these typos in v2.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-02-06 19:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 15:48 Andy Shevchenko
2025-02-06 19:13 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6UJ87h0QZ0HHmui@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=obitton@habana.ai \
--cc=ogabbay@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®