From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tamir Duberstein <tamird@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>, David Gow <davidgow@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v6 1/2] scanf: convert self-test to KUnit
Date: Tue, 11 Feb 2025 14:15:16 +0200 [thread overview]
Message-ID: <Z6s_VHExZe7ArgO7@smile.fi.intel.com> (raw)
In-Reply-To: <CAJ-ks9n5=FYiFdmzWCkkACzX6oEVs=Z261_ZAKVq3tkqgJoSCQ@mail.gmail.com>
On Tue, Feb 11, 2025 at 06:45:07AM -0500, Tamir Duberstein wrote:
> On Tue, Feb 11, 2025 at 6:37 AM Petr Mladek <pmladek@suse.com> wrote:
> > On Mon 2025-02-10 13:13:48, Tamir Duberstein wrote:
> > > + kunit_printk(KERN_DEBUG, test, "\"%s\", \"%s\" ->", str, fmt); \
> >
> > The switch from pr_debug() to kunit_printk() causes printing huge
> > amount of messages even when the test passes.
>
> I'm not able to reproduce this. pr_debug expands to printk(KERN_DEBUG,
> ...) which is also what kunit_printk(KERN_DEBUG, ...) expands to. Can
> you help me understand how you're testing?
You are missing something.
https://stackoverflow.com/a/57762255/2511795
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-02-11 12:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 18:13 [PATCH v6 0/2] " Tamir Duberstein
2025-02-10 18:13 ` [PATCH v6 1/2] " Tamir Duberstein
2025-02-11 11:37 ` Petr Mladek
2025-02-11 11:45 ` Tamir Duberstein
2025-02-11 12:15 ` Andy Shevchenko [this message]
2025-02-11 14:48 ` Tamir Duberstein
2025-02-11 16:06 ` Petr Mladek
2025-02-11 16:08 ` Tamir Duberstein
2025-02-10 18:13 ` [PATCH v6 2/2] scanf: break kunit into test cases Tamir Duberstein
2025-02-11 11:54 ` Petr Mladek
2025-02-11 15:11 ` Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6s_VHExZe7ArgO7@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=davidgow@google.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=shuah@kernel.org \
--cc=tamird@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®