From: Johan Hovold <johan@kernel.org>
To: Tony Chung <tony467913@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/3] drivers: usb: serial: mos7840: Add defines for clock select register offset
Date: Tue, 11 Feb 2025 10:44:13 +0100 [thread overview]
Message-ID: <Z6sb7QzdeWvcIxI4@hovoldconsulting.com> (raw)
In-Reply-To: <20241024100901.69883-2-tony467913@gmail.com>
On Thu, Oct 24, 2024 at 06:09:01PM +0800, Tony Chung wrote:
> This patch adds define for CLOCK_SELECT_REG1 & CLOCK_SELECT_REG2 offsets.
> These two registers can select clock source between 30M/96M/External.
I think should just add these as part of the patch that uses them. If
you have some information on how they are used, that would be useful to
have in the commit message and possibly also in a comment above the
defines.
Where did you learn about these settings?
Johan
next prev parent reply other threads:[~2025-02-11 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 10:08 [PATCH 0/3] drivers: usb: serial: mos7840: Improved baud rate support Tony Chung
2024-10-24 10:09 ` [PATCH 1/3] drivers: usb: serial: mos7840: Add defines for clock select register offset Tony Chung
2025-02-11 9:44 ` Johan Hovold [this message]
2024-10-24 10:09 ` [PATCH 2/3] drivers: usb: serial: mos7840: added optimized register setups for common baudrates Tony Chung
2025-02-11 10:16 ` Johan Hovold
2024-10-24 10:09 ` [PATCH 3/3] driver: usb: serial: mos7840: add more baudrate options Tony Chung
2025-02-11 13:08 ` Johan Hovold
2025-02-11 9:41 ` [PATCH 0/3] drivers: usb: serial: mos7840: Improved baud rate support Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6sb7QzdeWvcIxI4@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony467913@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®