From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
Eric Biggers <ebiggers@kernel.org>,
fsverity@lists.linux.dev, linux-crypto@vger.kernel.org,
dm-devel@lists.linux.dev, x86@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Sami Tolvanen <samitolvanen@google.com>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mikulas Patocka <mpatocka@redhat.com>,
David Howells <dhowells@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v8 0/7] Optimize dm-verity and fsverity using multibuffer hashing
Date: Tue, 18 Feb 2025 16:02:29 +0800 [thread overview]
Message-ID: <Z7Q-lRwkCbXFpgXS@gondor.apana.org.au> (raw)
In-Reply-To: <CAMj1kXFe2f0cCYznorrO-wJyh-qxJP5z-HdR9rbQiuMKC5u6qw@mail.gmail.com>
On Tue, Feb 18, 2025 at 08:41:57AM +0100, Ard Biesheuvel wrote:
>
> And for IPsec, I'd assume that the cryptd fallback is only needed when
> TX and RX are competing for the same CPU.
Which can happen if the system is handling encrypted data in both
directions. Sometimes you do want to have the hardware steer a
given flow to the same CPU in both directions.
> So for modern systems, I don't think the SIMD helper does anything
> useful, and we should just remove it, especially if we can relax the
> softirq/preemption rules for kernel SIMD on x86 like I did for arm64.
Sure, if we can ensure that SIMD is always useable even in softirq
context then we should definitely remove the simd wrapper. But until
that happens, suddenly switching from AESNI to the generic C
implementation because a system is loaded is not good.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-02-18 8:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 15:47 Eric Biggers
2025-02-12 15:47 ` [PATCH v8 1/7] crypto: shash - add support for finup_mb Eric Biggers
2025-02-12 15:47 ` [PATCH v8 2/7] crypto: testmgr - add tests " Eric Biggers
2025-02-12 15:47 ` [PATCH v8 3/7] crypto: x86/sha256-ni - add support " Eric Biggers
2025-02-12 15:47 ` [PATCH v8 4/7] crypto: arm64/sha256-ce " Eric Biggers
2025-02-12 15:47 ` [PATCH v8 5/7] fsverity: improve performance by using multibuffer hashing Eric Biggers
2025-02-12 15:47 ` [PATCH v8 6/7] dm-verity: reduce scope of real and wanted digests Eric Biggers
2025-02-12 15:47 ` [PATCH v8 7/7] dm-verity: improve performance by using multibuffer hashing Eric Biggers
2025-02-13 4:17 ` [PATCH v8 0/7] Optimize dm-verity and fsverity " Herbert Xu
2025-02-13 6:33 ` Eric Biggers
2025-02-14 2:44 ` Herbert Xu
2025-02-14 3:35 ` Eric Biggers
2025-02-14 3:50 ` Herbert Xu
2025-02-14 4:29 ` Eric Biggers
2025-02-14 4:56 ` Herbert Xu
2025-02-14 6:11 ` Eric Biggers
2025-02-14 10:50 ` Ard Biesheuvel
2025-02-15 17:04 ` Jakub Kicinski
2025-02-16 2:27 ` Herbert Xu
2025-02-16 3:26 ` Eric Biggers
2025-02-16 3:29 ` Herbert Xu
2025-02-17 17:40 ` Jakub Kicinski
2025-02-18 3:42 ` Herbert Xu
2025-02-18 7:41 ` Ard Biesheuvel
2025-02-18 8:02 ` Herbert Xu [this message]
2025-02-13 10:10 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7Q-lRwkCbXFpgXS@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=agk@redhat.com \
--cc=ardb@kernel.org \
--cc=dhowells@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=snitzer@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®