mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Sang <oliver.sang@intel.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: <oe-lkp@lists.linux.dev>, <lkp@intel.com>,
	Petr Pavlu <petr.pavlu@suse.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	<linux-kernel@vger.kernel.org>, <oliver.sang@intel.com>
Subject: Re: [linux-next:master] [x86]  66fbf67705: kernel-selftests.kvm.hardware_disable_test.fail
Date: Thu, 20 Feb 2025 15:04:43 +0800	[thread overview]
Message-ID: <Z7bUC9QY815Cv6nb@xsang-OptiPlex-9020> (raw)
In-Reply-To: <20250218144918.Rl33HhXh@linutronix.de>

hi, Sebastian,

On Tue, Feb 18, 2025 at 03:49:18PM +0100, Sebastian Andrzej Siewior wrote:
> On 2025-02-14 10:03:18 [+0800], kernel test robot wrote:
> > kernel test robot noticed "kernel-selftests.kvm.hardware_disable_test.fail" on:
> > 
> > commit: 66fbf677051818b9b5339fa8bfeac1b2e288efa5 ("x86: Use RCU in all users of __module_address().")
> > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
> > 
> > [test failed on linux-next/master df5d6180169ae06a2eac57e33b077ad6f6252440]
> > 
> > # timeout set to 120
> > # selftests: kvm: hardware_disable_test
> > # Random seed: 0x6b8b4567
> > #
> > not ok 73 selftests: kvm: hardware_disable_test # TIMEOUT 120 seconds
> 
> I've been playing with that. It completed after ~45secs. The linked
> dmesg had also mmu_stress_test timed out but it completed here, too.
> I had a timeout in access_tracking_perf_test and memslot_perf_test.
> 
> The box is very sluggish. LOCKDEP, KASAN and maybe UBSAN cause that. I
> would say the commit in question is innocent.

just FYI. we rebuild the kernel, and run the tests more times upon this commit
and its parent, still see the issue persistent:

=========================================================================================
tbox_group/testcase/rootfs/kconfig/compiler/group:
  lkp-skl-d06/kernel-selftests/debian-12-x86_64-20240206.cgz/x86_64-rhel-9.4-kselftests/gcc-12/kvm

f985e39203090cc6 66fbf677051818b9b5339fa8bfe
---------------- ---------------------------
       fail:runs  %reproduction    fail:runs
           |             |             |
           :20         105%          20:20    kernel-selftests.kvm.hardware_disable_test.fail
         %stddev     %change         %stddev
             \          |                \
    580.92           +17.4%     682.06        kernel-selftests.time.elapsed_time
    580.92           +17.4%     682.06        kernel-selftests.time.elapsed_time.max
    550.23           +13.1%     622.20        kernel-selftests.time.system_time

as above, the time spent is also longer, though it's not only for
kvm.hardware_disable_test (the time is for whole kernel-selftests.kvm)

it seems to us that the commit really causes some slow down and it happens to
make kvm.hardware_disable_test timeout on the older machine for our original
report:

4 threads Intel(R) Xeon(R) CPU E3-1225 v5 @ 3.30GHz (Skylake) with 16G memory


then we make same tests on another newer platform:

224 threads Intel(R) Xeon(R) Platinum 8480+ with 256G memory


we see the test pass on both this commit and its parent. but the time spent is
still longer (again, for full kernel-selftests.kvm)

=========================================================================================
compiler/group/kconfig/rootfs/tbox_group/testcase:
  gcc-12/kvm/x86_64-rhel-9.4-kselftests/debian-12-x86_64-20240206.cgz/lkp-spr-2sp1/kernel-selftests

f985e39203090cc6 66fbf677051818b9b5339fa8bfe
---------------- ---------------------------
       fail:runs  %reproduction    fail:runs
           |             |             |
         10:10           0%          10:10    kernel-selftests.kvm.hardware_disable_test.pass
         %stddev     %change         %stddev
             \          |                \
    238.99 ±  2%      +7.1%     255.89 ±  5%  kernel-selftests.time.elapsed_time
    238.99 ±  2%      +7.1%     255.89 ±  5%  kernel-selftests.time.elapsed_time.max
      1130 ±  2%     +31.4%       1486 ± 68%  kernel-selftests.time.system_time

> 
> Sebastian

  reply	other threads:[~2025-02-20  7:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-14  2:03 kernel test robot
2025-02-18 14:49 ` Sebastian Andrzej Siewior
2025-02-20  7:04   ` Oliver Sang [this message]
2025-02-20 15:57     ` Sebastian Andrzej Siewior
2025-02-20 16:30       ` Marco Elver
2025-02-21  9:00         ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7bUC9QY815Cv6nb@xsang-OptiPlex-9020 \
    --to=oliver.sang@intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mingo@redhat.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=peterz@infradead.org \
    --cc=petr.pavlu@suse.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®