From: John Keeping <jkeeping@inmusicbrands.com>
To: Wentao Guan <guanwentao@uniontech.com>
Cc: andriy.shevchenko@linux.intel.com, arnd@arndb.de,
fancer.lancer@gmail.com, ftoth@exalondelft.nl,
gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
ilpo.jarvinen@linux.intel.com, jirislaby@kernel.org,
john.ogness@linutronix.de, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, pmladek@suse.com,
schnelle@linux.ibm.com, stable@vger.kernel.org,
sunilvl@ventanamicro.com
Subject: Re: [PATCH v3] serial: 8250: Fix fifo underflow on flush
Date: Mon, 24 Feb 2025 12:18:16 +0000 [thread overview]
Message-ID: <Z7xjiPA7nziASvC7-jkeeping@inmusicbrands.com> (raw)
In-Reply-To: <20250222132627.25818-1-guanwentao@uniontech.com>
On Sat, Feb 22, 2025 at 09:26:27PM +0800, Wentao Guan wrote:
> It seems strange that call 'dmaengine_terminate_async( **dma->rxchan** );' in
> 'serial8250_ **tx** _dma_flush' during code review.
> I am not a professional reviewer in this module, could you explaim the change?
It's a typo! Nice catch, I will send a patch to fix this.
Regards,
John
next prev parent reply other threads:[~2025-02-24 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 12:41 John Keeping
2025-02-22 13:26 ` Wentao Guan
2025-02-24 12:18 ` John Keeping [this message]
2026-01-30 3:54 ` Raul E Rangel
[not found] <2025021859-renewal-onto-1877@gregkh>
2025-02-22 13:13 ` Wentao Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7xjiPA7nziASvC7-jkeeping@inmusicbrands.com \
--to=jkeeping@inmusicbrands.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=fancer.lancer@gmail.com \
--cc=ftoth@exalondelft.nl \
--cc=gregkh@linuxfoundation.org \
--cc=guanwentao@uniontech.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=schnelle@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=sunilvl@ventanamicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®