From: "Heiko Stübner" <heiko@sntech.de>
To: Tomeu Vizoso <tomeu@tomeuvizoso.net>,
Oded Gabbay <ogabbay@kernel.org>,
Jeff Hugo <jeff.hugo@oss.qualcomm.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Guangshuo Li <lgs201920130244@gmail.com>,
Guangshuo Li <lgs201920130244@gmail.com>
Subject: Re: [PATCH] accel/rocket: put IOMMU domain on BO creation failure
Date: Sun, 15 Nov 2026 21:51:18 +0100 [thread overview]
Message-ID: <Z8-0sxgbQR2_ndmAA6Kohg@sntech.de> (raw)
In-Reply-To: <20260708114354.753817-1-lgs201920130244@gmail.com>
Am Mittwoch, 8. Juli 2026, 13:43:54 Mitteleuropäische Normalzeit schrieb Guangshuo Li:
> rocket_ioctl_create_bo() takes an IOMMU domain reference for each newly
> created BO.
>
> The normal GEM object release path drops that reference from
> rocket_gem_bo_free(). However, the BO creation error paths free the
> object with drm_gem_shmem_object_free(), which bypasses the driver's GEM
> .free callback. Those paths therefore release the shmem object without
> dropping the IOMMU domain reference.
>
> Drop the domain reference explicitly on the BO creation error path before
> freeing the shmem object.
>
> Fixes: 658ebeac3351 ("accel/rocket: Add IOCTL for BO creation")
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
prev parent reply other threads:[~2026-11-15 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 11:43 Guangshuo Li
2026-11-15 20:51 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8-0sxgbQR2_ndmAA6Kohg@sntech.de \
--to=heiko@sntech.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jeff.hugo@oss.qualcomm.com \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=tomeu@tomeuvizoso.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®