From: Gregory Price <gourry@gourry.net>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: krisman@collabora.com, tglx@linutronix.de, luto@kernel.org,
peterz@infradead.org, keescook@chromium.org,
gregory.price@memverge.com, Marco Elver <elver@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] selftests: Fix errno checking in syscall_user_dispatch test
Date: Mon, 3 Mar 2025 11:06:50 -0500 [thread overview]
Message-ID: <Z8XTmnRo5opCojnH@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <d11d91e0c27ef78affcef06e00d1cf4cd8747fcc.1740386567.git.dvyukov@google.com>
On Mon, Feb 24, 2025 at 09:45:26AM +0100, Dmitry Vyukov wrote:
> /* len != 0 */
> - prctl(PR_SET_SYSCALL_USER_DISPATCH, op, 0x0, 0xff, 0);
> + EXPECT_EQ(-1, prctl(PR_SET_SYSCALL_USER_DISPATCH, op, 0x0, 0xff, 0));
> EXPECT_EQ(EINVAL, errno);
This patch should probably just be pulled ahead of everything else,
since you change the behavior of the syscall, and now you're updating
the test - but it will fail (since this no longer produces EINVAL).
This patch should probably just be entirely separate, maybe even in
stable?
~Gregory
next prev parent reply other threads:[~2025-03-03 16:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1740386567.git.dvyukov@google.com>
2025-02-24 8:45 ` [PATCH v2 1/3] syscall_user_dispatch: Allow allowed range wrap-around Dmitry Vyukov
2025-03-08 10:00 ` Dmitry Vyukov
2025-03-08 11:19 ` Thomas Gleixner
2025-05-21 15:05 ` Dmitry Vyukov
2025-02-24 8:45 ` [PATCH v2 2/3] selftests: Fix errno checking in syscall_user_dispatch test Dmitry Vyukov
2025-03-03 16:06 ` Gregory Price [this message]
2025-03-08 9:57 ` Dmitry Vyukov
2025-03-08 12:34 ` Thomas Gleixner
2025-05-21 10:07 ` Dmitry Vyukov
2025-05-21 11:10 ` Thomas Weißschuh
2025-05-21 13:00 ` Dmitry Vyukov
2025-02-24 8:45 ` [PATCH v2 3/3] selftests: Extend syscall_user_dispatch test to check allowed range Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8XTmnRo5opCojnH@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=gregory.price@memverge.com \
--cc=keescook@chromium.org \
--cc=krisman@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®