From: Frank Li <Frank.li@nxp.com>
To: Stefan Eichenberger <eichest@gmail.com>
Cc: vkoul@kernel.org, kishon@kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, p.zabel@pengutronix.de,
tharvey@gateworks.com, hongxing.zhu@nxp.com,
francesco.dolcini@toradex.com, linux-phy@lists.infradead.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Stefan Eichenberger <stefan.eichenberger@toradex.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] phy: freescale: imx8m-pcie: assert phy reset and perst in power off
Date: Wed, 5 Mar 2025 10:42:13 -0500 [thread overview]
Message-ID: <Z8hw1W0PBsmanylZ@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250305144355.20364-3-eichest@gmail.com>
On Wed, Mar 05, 2025 at 03:43:16PM +0100, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
>
> Ensure the PHY reset and perst is asserted during power-off to
> guarantee it is in a reset state upon repeated power-on calls. This
> resolves an issue where the PHY may not properly initialize during
> subsequent power-on cycles. Power-on will deassert the reset at the
> appropriate time after tuning the PHY parameters.
>
> During suspend/resume cycles, we observed that the PHY PLL failed to
> lock during resume when the CPU temperature increased from 65C to 75C.
> The observed errors were:
> phy phy-32f00000.pcie-phy.3: phy poweron failed --> -110
> imx6q-pcie 33800000.pcie: waiting for PHY ready timeout!
> imx6q-pcie 33800000.pcie: PM: dpm_run_callback(): genpd_resume_noirq+0x0/0x80 returns -110
> imx6q-pcie 33800000.pcie: PM: failed to resume noirq: error -110
>
> This resulted in a complete CPU freeze, which is resolved by ensuring
> the PHY is in reset during power-on, thus preventing PHY PLL failures.
>
> Cc: stable@vger.kernel.org
> Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver")
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> index 5b505e34ca364..7355d9921b646 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> @@ -156,6 +156,16 @@ static int imx8_pcie_phy_power_on(struct phy *phy)
> return ret;
> }
>
> +static int imx8_pcie_phy_power_off(struct phy *phy)
> +{
> + struct imx8_pcie_phy *imx8_phy = phy_get_drvdata(phy);
> +
> + reset_control_assert(imx8_phy->reset);
> + reset_control_assert(imx8_phy->perst);
> +
> + return 0;
> +}
> +
> static int imx8_pcie_phy_init(struct phy *phy)
> {
> struct imx8_pcie_phy *imx8_phy = phy_get_drvdata(phy);
> @@ -176,6 +186,7 @@ static const struct phy_ops imx8_pcie_phy_ops = {
> .init = imx8_pcie_phy_init,
> .exit = imx8_pcie_phy_exit,
> .power_on = imx8_pcie_phy_power_on,
> + .power_off = imx8_pcie_phy_power_off,
> .owner = THIS_MODULE,
> };
>
> --
> 2.45.2
>
next prev parent reply other threads:[~2025-03-05 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 14:43 [PATCH v2 0/2] phy: freescale: imx8m-pcie: fix and cleanup phy Stefan Eichenberger
2025-03-05 14:43 ` [PATCH v2 1/2] phy: freescale: imx8m-pcie: cleanup reset logic Stefan Eichenberger
2025-03-05 15:40 ` Frank Li
2025-03-05 14:43 ` [PATCH v2 2/2] phy: freescale: imx8m-pcie: assert phy reset and perst in power off Stefan Eichenberger
2025-03-05 15:42 ` Frank Li [this message]
2025-03-06 0:24 ` [PATCH v2 0/2] phy: freescale: imx8m-pcie: fix and cleanup phy Hongxing Zhu
2025-03-10 20:13 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8hw1W0PBsmanylZ@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=eichest@gmail.com \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=stefan.eichenberger@toradex.com \
--cc=tharvey@gateworks.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®