From: Francesco Dolcini <francesco@dolcini.it>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
Kalle Valo <kvalo@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: mwifiex: Constify struct mwifiex_if_ops
Date: Fri, 7 Mar 2025 10:29:18 +0100 [thread overview]
Message-ID: <Z8q8bleeyyavuNeA@gaggiata.pivistrello.it> (raw)
In-Reply-To: <03d524b72f20a0302e4de5e0ebdc20ab69469dec.1737308889.git.christophe.jaillet@wanadoo.fr>
On Sun, Jan 19, 2025 at 06:48:39PM +0100, Christophe JAILLET wrote:
> 'struct mwifiex_if_ops' are not modified in these drivers.
>
> Constifying these structures moves some data to a read-only section, so
> increase overall security, especially when the structure holds some
> function pointers.
>
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
> text data bss dec hex filename
> 61439 4367 32 65838 1012e drivers/net/wireless/marvell/mwifiex/pcie.o
>
> After:
> =====
> text data bss dec hex filename
> 61699 4127 32 65858 10142 drivers/net/wireless/marvell/mwifiex/pcie.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> Compile tested-only.
I did also a brief smoke test on 88W8997, and the driver just probe fines.
Tested-by: Francesco Dolcini <francesco.dolcini@toradex.com> # Verdin iMX8MM - 88W8997
prev parent reply other threads:[~2025-03-07 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-19 17:48 Christophe JAILLET
2025-01-28 18:12 ` Kalle Valo
2025-03-07 9:29 ` Francesco Dolcini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8q8bleeyyavuNeA@gaggiata.pivistrello.it \
--to=francesco@dolcini.it \
--cc=briannorris@chromium.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®