mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Ricardo Ribalda <ribalda@chromium.org>,
	linux-kernel@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org
Subject: Re: [v2,1/1] media: v4l2-core: Replace the check for firmware registered I²C devices
Date: Thu, 13 Mar 2025 13:15:58 +0200	[thread overview]
Message-ID: <Z9K-bh9uxzA1x1QA@smile.fi.intel.com> (raw)
In-Reply-To: <4633173e-111a-4659-945d-149e3857896c@xs4all.nl>

On Thu, Mar 13, 2025 at 10:52:25AM +0100, Hans Verkuil wrote:
> On 13/03/2025 10:05, Andy Shevchenko wrote:
> > On Wed, Mar 12, 2025 at 02:06:16PM -0700, Patchwork Integration wrote:
> >> Dear Andy Shevchenko:
> >>
> >> Thanks for your patches! Unfortunately the Media CI robot detected some
> >> issues:
> >>
> >> # Test media-patchstyle:./0001-media-v4l2-core-Replace-the-check-for-firmware-regis.patch media style
> >> ERROR: ./0001-media-v4l2-core-Replace-the-check-for-firmware-regis.patch: Missing 'media:' prefix in Subject
> > 
> > LOL, what?
> 
> Hmm, the 'I²C' bit in the Subject header causes it to be UTF-8. The Subject line in
> patchwork (1) is now:
> 
> Subject: [PATCH v2 1/1] =?utf-8?q?media=3A_v4l2-core=3A_Replace_the_check_fo?=
>         =?utf-8?q?r_firmware_registered_I=C2=B2C_devices?=
> 
> so the check for the 'media:' prefix in the Subject line fails.
> 
> Interestingly, if I commit the patch (git am) to a test branch, then run
> 'git format-patch -n1' the Subject line now reads:
> 
> Subject: [PATCH 1/1] =?UTF-8?q?media:=20v4l2-core:=20Replace=20the=20check?=
>  =?UTF-8?q?=20for=20firmware=20registered=20I=C2=B2C=20devices?=
> 
> and that restored the ':'.
> 
> Ricardo, can you look at this?
> 
> I also noticed that the v1 and v2 patches ended up in my spam folder. Whether that
> is related to UTF-8 in the Subject is not clear (my provider marks way too many
> legit posts as spam).
> 
> Andy, can you post a v3 with just 'I2C' in the subject instead of 'I²C'? If nothing
> else, I'd like to know if that's the reason it ended up in my spam folder.

Sure. Will do ASAP.

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2025-03-13 11:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12 19:24 [PATCH v2 1/1] " Andy Shevchenko
     [not found] ` <67d1f748.050a0220.353790.339b@mx.google.com>
2025-03-13  9:05   ` [v2,1/1] " Andy Shevchenko
2025-03-13  9:52     ` Hans Verkuil
2025-03-13 10:29       ` Ricardo Ribalda
2025-03-13 11:15       ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9K-bh9uxzA1x1QA@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=ribalda@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®