From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E6CD1EE7C0 for ; Fri, 14 Mar 2025 09:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741944607; cv=none; b=IajKatKU4EiMKJsLux7vz4p5qO6Nhmzzm879bjZIGwDURp9Y2cRkYqJfuyrUfrjPOxHzJ3RKPmDsthlsaZQNmV+rgdO3dMam3ZsjD5n8jZ+4yVQw/ZCTQk70y4lP0UYDy2mCkDpiNl6LigtU7659vPBmd8W5JAJCez7KBx8ztv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741944607; c=relaxed/simple; bh=7B240d6j4OExyYUlEP6p1T29DEbvNYI/esoZe1OK7gk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=jzSelB3Du4M5yGP1Z4+f4hE98UgAq/XCK40ZDHjtS+Ck2RrrcmVIFNJjDu9/p9vxdZJmJ0vws2/mokoIBFLKhSKxg8t0h8qD+VEdv6XZcwH4V8eWGcVlcLTetBCdiEEt//0OfDGvS2jWxlQbZAt8kOWCVpagKcHLJzBQZg4V3xA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=IPZL8LzS; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IPZL8LzS" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43cf446681cso11405095e9.1 for ; Fri, 14 Mar 2025 02:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741944604; x=1742549404; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Vx9uDZ+QhqTeL0tFVgUFI0Mccb4hWoxO0D5VjPF0f/8=; b=IPZL8LzS9tOCQ0S+AH4kPiVCGnlVWSESVv5zBy9gSpbikcedFza/jF9wy4h9xd2i8R Rt3KAAbqa+4qKGiFqtBFfcXb7d1x14w8DVh8P69n/mfbRdiTRtFhzj71aUPw3acWxIe2 p3rNID1l4xZmVPmDMgUGpmazPqx7oXS1ClVfZce7Fk1SMxFOYRlgmwxBEYu/ZnF3vviE WdqDZfrnHsHqwnfCe6p/Le6+DTsnxXy8OTxeIpwTqbDu6xx2mJoqeP+ic7H5Q5NR6K0/ jEflLvmHJYRmjB4A5nSWSKu2qiybo6CXziaCp6z34HVFkgj1JGMwJvdaw+T4bTymdYkP rsCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741944604; x=1742549404; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vx9uDZ+QhqTeL0tFVgUFI0Mccb4hWoxO0D5VjPF0f/8=; b=A+Avhtl0kkSIHTTKWuLdNVrhb/xKqBf5rhyFGJ2RlvKEFUthslrucb5LhYwjSuYMxf BbkSebyKeNty94ExaqeKYb8BXHZR7y2U5ZfnMc4J0sSYLppzK2ImSPrbtL8khSFwehXb GRkWpAq6RHufp7aB018r6+xeG273r87FbCVuN9lvisSM7Xslv90K2dqeMt8bG1X9nL0Q gbhGwv5qb4eiHWPgtyLaWx9TYBX+pBsc+JSBHxrhtkaBYVY/CfeFGiW1VYd9ezJhI5a4 EOXl7sJ50d63JWj//WY8iGcv1cWPYMba+XGXemq/dhKIFVxRmIQZV5VoTRoHNdTnJq77 IcJQ== X-Forwarded-Encrypted: i=1; AJvYcCVEBuwd+WgssrXUbeU1f8dXUWgM3ARoozNFBsnkuHuP6jSHNUmgjHARI+IuWftQHigD1qKC4EP4c5UqTAM=@vger.kernel.org X-Gm-Message-State: AOJu0YydJmzfco3duqZI7rLQdgyJj/bAeLBzxX7xMpk42MEFVwliQSo6 4Cf1W4oBmY34ncWKspcaZpioVcsUW9YrsND38n1XtQOCSIgaEHrb5utpluxTVRH5AytYUwRw4g/ 14i4WfhNd7WXBHw== X-Google-Smtp-Source: AGHT+IGDsrKK697tTln1RD7AuELwm2Txn2iyfq75zdHGM/J4mNu5ImB/Z+SRHD/kqQ29qRrXLQhTzZpkycOOh54= X-Received: from wmbay4.prod.google.com ([2002:a05:600c:1e04:b0:43c:ef7b:ffac]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4708:b0:43c:f050:fed3 with SMTP id 5b1f17b1804b1-43d1ec78842mr25457025e9.11.1741944603897; Fri, 14 Mar 2025 02:30:03 -0700 (PDT) Date: Fri, 14 Mar 2025 09:30:01 +0000 In-Reply-To: <20250311-inline-c-wrappers-v2-1-72c99d35ff33@posteo.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-inline-c-wrappers-v2-1-72c99d35ff33@posteo.net> Message-ID: Subject: Re: [PATCH v2] rust: task: mark Task methods inline From: Alice Ryhl To: Panagiotis Foliadis Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="utf-8" On Tue, Mar 11, 2025 at 03:05:52PM +0000, Panagiotis Foliadis wrote: > When you build the kernel using the llvm-18.1.3-rust-1.85.0-x86_64 > toolchain provided by kernel.org, the following symbols are generated: > > $ nm vmlinux | grep ' _R'.*Task | rustfilt > ffffffff817b2d30 T ::get_pid_ns > ffffffff817b2d50 T ::tgid_nr_ns > ffffffff817b2c90 T ::current_pid_ns > ffffffff817b2d00 T ::signal_pending > ffffffff817b2cc0 T ::uid > ffffffff817b2ce0 T ::euid > ffffffff817b2c70 T ::current > ffffffff817b2d70 T ::wake_up > ffffffff817b2db0 T ::dec_ref > ffffffff817b2d90 T ::inc_ref > > These Rust symbols are trivial wrappers around the C functions > get_pid_ns, task_tgid_nr_ns, task_active_pid_ns, signal_pending, uid, > euid, get_current, wake_up, get_task_struct and put_task_struct.It > doesn't make sense to go through a trivial wrapper for these > functions, so mark them inline. Typo: "put_task_struct.It" > After applying this patch, the above command will produce no output. > > Link: https://github.com/Rust-for-Linux/linux/issues/1145 > Signed-off-by: Panagiotis Foliadis Reviewed-by: Alice Ryhl