From: Abel Vesa <abel.vesa@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: x1e001de-devkit: fix USB retimer reset polarity
Date: Tue, 18 Mar 2025 16:57:02 +0200 [thread overview]
Message-ID: <Z9mJvh2KGwhOJ6I9@linaro.org> (raw)
In-Reply-To: <20250318074907.13903-1-johan+linaro@kernel.org>
On 25-03-18 08:49:07, Johan Hovold wrote:
> The ps8830 retimer reset is active low.
>
> Fix up the retimer nodes which were based on an early version of the
> driver which inverted the polarity.
>
> Fixes: 019e1ee32fec ("arm64: dts: qcom: x1e001de-devkit: Enable external DP support")
> Cc: Sibi Sankar <quic_sibis@quicinc.com>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> index f92bda2d34f2..dc1a8f5d485a 100644
> --- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> @@ -788,7 +788,7 @@ typec-mux@8 {
> vddat-supply = <&vreg_rtmr2_1p15>;
> vddio-supply = <&vreg_rtmr2_1p8>;
>
> - reset-gpios = <&tlmm 185 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&tlmm 185 GPIO_ACTIVE_LOW>;
>
> orientation-switch;
> retimer-switch;
> @@ -843,7 +843,7 @@ typec-mux@8 {
> vddat-supply = <&vreg_rtmr0_1p15>;
> vddio-supply = <&vreg_rtmr0_1p8>;
>
> - reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_LOW>;
>
> retimer-switch;
> orientation-switch;
> @@ -898,7 +898,7 @@ typec-mux@8 {
> vddat-supply = <&vreg_rtmr1_1p15>;
> vddio-supply = <&vreg_rtmr1_1p8>;
>
> - reset-gpios = <&tlmm 176 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&tlmm 176 GPIO_ACTIVE_LOW>;
>
> retimer-switch;
> orientation-switch;
> --
> 2.48.1
>
next prev parent reply other threads:[~2025-03-18 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 7:49 Johan Hovold
2025-03-18 12:18 ` Konrad Dybcio
2025-03-18 14:57 ` Abel Vesa [this message]
2025-03-19 14:19 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9mJvh2KGwhOJ6I9@linaro.org \
--to=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_sibis@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®