From: Richard Cochran <richardcochran@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Horatiu Vultur <horatiu.vultur@microchip.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net-next v3] net: phy: micrel: Add support for PTP_PF_PEROUT for lan8841
Date: Sun, 12 Mar 2023 19:31:52 -0700 [thread overview]
Message-ID: <ZA6LGJZ2nWunT1xE@hoboy.vegasvil.org> (raw)
In-Reply-To: <20230310163824.5f5f653e@kernel.org>
On Fri, Mar 10, 2023 at 04:38:24PM -0800, Jakub Kicinski wrote:
> AFAICT enabling a new output will steal the event from the previous one.
> Is this normal / expected? Should you be checking if any output is
> active and refuse to enable another GPIO if so?
The PTP class layer takes care of enabling and switching of functions
among the pins. The functions (like periodic output) and the pins are
independent. The user may free assign functions to pins, and
re-assign them at will.
When switching, class layer ensures that the pin support the function,
and it also takes care of disabling functions to avoid weird behavior.
See ptp_disable_pinfunc and ptp_set_pinfunc in drivers/ptp/ptp_chardev.c
> Richard, does the patch look good to you?
Yes, looks reasonable, mostly hardware specific.
Thanks,
Richard
next prev parent reply other threads:[~2023-03-13 2:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 21:44 Horatiu Vultur
2023-03-11 0:38 ` Jakub Kicinski
2023-03-13 2:31 ` Richard Cochran [this message]
2023-03-13 22:35 ` Jakub Kicinski
2023-03-13 22:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA6LGJZ2nWunT1xE@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®