From: Yury Norov <yury.norov@gmail.com>
To: Gavin Shan <gshan@redhat.com>
Cc: linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com,
linux@rasmusvillemoes.dk, shan.gavin@gmail.com
Subject: Re: [PATCH] nodemask: Drop duplicate check in for_each_node_mask()
Date: Wed, 1 Mar 2023 23:05:33 -0800 [thread overview]
Message-ID: <ZABKvSq9TQxxQnu7@yury-laptop> (raw)
In-Reply-To: <20230124000243.415621-1-gshan@redhat.com>
On Tue, Jan 24, 2023 at 08:02:43AM +0800, Gavin Shan wrote:
> The return value type is changed from 'int' to 'unsigned int' since
> commit 0dfe54071d7c8 ("nodemask: Fix return values to be unsigned").
> Besides, the conversion between 'int' and 'unsigned int' on the
> parameter @node is guaranteed to be safe due to the limited range of
> MAX_NUMNODES and CONFIG_NODES_SHIFT. By the way, '(node >= 0)' should
> have been '(node) >= 0' actually.
>
> It's unnecessary to check if their return values are greater or equal
> to 0 in for_each_node_mask(). Remove it.
>
> No functional change intended.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2023-03-02 7:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 0:02 Gavin Shan
2023-01-24 10:24 ` Andy Shevchenko
2023-03-02 7:05 ` Yury Norov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZABKvSq9TQxxQnu7@yury-laptop \
--to=yury.norov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gshan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=shan.gavin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®