mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Yue Hu <zbestahu@gmail.com>
Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
	huyue2@coolpad.com, zhangwen@coolpad.com
Subject: Re: [PATCH] workqueue: Drop the NOT_RUNNING check to flags in worker_{set,clr}_flags
Date: Thu, 23 Mar 2023 15:58:27 -1000	[thread overview]
Message-ID: <ZB0Dwxs6xen7D/qh@slm.duckdns.org> (raw)
In-Reply-To: <20230320092652.16649-1-zbestahu@gmail.com>

On Mon, Mar 20, 2023 at 05:26:52PM +0800, Yue Hu wrote:
> From: Yue Hu <huyue2@coolpad.com>
> 
> We know whether the worker flags are belong to WORKER_NOT_RUNNING or not
> when we are setting and clearing them.  So check the flags not running
> related is unnecessary for both the cases.
> 
> Currently, worker_{set,clr}_flags() are all used for WORKER_NOT_RUNNING
> except for clearing WORKER_IDLE.  Let's change to directly clear it
> instead.  Also, update the comment a little in worker_clr_flags().

I'm not sure this is better. Semantically, the existing code seems clearer
and less error-prone to me and this isn't gonna make any meaningful perf
difference. Lai, what do you think?

Thanks.

-- 
tejun

  reply	other threads:[~2023-03-24  1:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20  9:26 Yue Hu
2023-03-24  1:58 ` Tejun Heo [this message]
2023-03-25  9:20   ` Lai Jiangshan
2023-03-27  3:07     ` Yue Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZB0Dwxs6xen7D/qh@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=huyue2@coolpad.com \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zbestahu@gmail.com \
    --cc=zhangwen@coolpad.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®