From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC3DAC76196 for ; Fri, 24 Mar 2023 10:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231681AbjCXK2y (ORCPT ); Fri, 24 Mar 2023 06:28:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229917AbjCXK2v (ORCPT ); Fri, 24 Mar 2023 06:28:51 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78F742201F; Fri, 24 Mar 2023 03:28:44 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1pfeeo-008FYb-Dn; Fri, 24 Mar 2023 18:28:27 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 24 Mar 2023 18:28:26 +0800 Date: Fri, 24 Mar 2023 18:28:26 +0800 From: Herbert Xu To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Dan Williams , "David S. Miller" , linux-crypto@vger.kernel.org Subject: Re: [PATCH v2] async_tx: fix kernel-doc notation warnings Message-ID: References: <20230314024734.9066-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230314024734.9066-1-rdunlap@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 13, 2023 at 07:47:34PM -0700, Randy Dunlap wrote: > Fix kernel-doc warnings by adding "struct" keyword or "enum" keyword. > Also fix 2 function parameter descriptions. > Change some functions and structs from kernel-doc /** notation > to regular /* comment notation. > > async_pq.c:18: warning: cannot understand function prototype: 'struct page *pq_scribble_page; ' > async_pq.c:18: error: Cannot parse struct or union! > async_pq.c:40: warning: No description found for return value of 'do_async_gen_syndrome' > async_pq.c:109: warning: Function parameter or member 'blocks' not described in 'do_sync_gen_syndrome' > async_pq.c:109: warning: Function parameter or member 'offsets' not described in 'do_sync_gen_syndrome' > async_pq.c:109: warning: Function parameter or member 'disks' not described in 'do_sync_gen_syndrome' > async_pq.c:109: warning: Function parameter or member 'len' not described in 'do_sync_gen_syndrome' > async_pq.c:109: warning: Function parameter or member 'submit' not described in 'do_sync_gen_syndrome' > > async_tx.c:136: warning: cannot understand function prototype: 'enum submit_disposition ' > async_tx.c:264: warning: Function parameter or member 'tx' not described in 'async_tx_quiesce' > > Signed-off-by: Randy Dunlap > Cc: Dan Williams > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: linux-crypto@vger.kernel.org > --- > v2: fix more warnings > > crypto/async_tx/async_pq.c | 10 +++++----- > crypto/async_tx/async_tx.c | 4 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt