From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E81E5C76195 for ; Fri, 24 Mar 2023 09:05:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231854AbjCXJFy (ORCPT ); Fri, 24 Mar 2023 05:05:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230102AbjCXJFw (ORCPT ); Fri, 24 Mar 2023 05:05:52 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A426E136CA; Fri, 24 Mar 2023 02:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679648751; x=1711184751; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=8lGzd2l365WJAtOkQ45lcxnK6kVGkUm4YJQ0Jombmr8=; b=PQWLRXVl6g4DWQ1OovyZu5b4J0w9RRW7aFtkSTpEcYj6RztkbIm00Q9F aEMgvLqBIZojP2qsIkyKsxf0Lm9xG2st2SQQ9hYhzQRmgU2rBTmn33zmJ CZiwFuDHnPC4c4wCqCXQH2RGWqdpsf0nUXp4Xua6QutqUCVpVYnfnPiM7 bpIe3vZwTBaGIpI5GVq4RL9m2cVKwYjlME4RXLTSmPH9CqilIcyHE3Cy0 syWLemhOJS1/qJHA3sLAZr4eCCr1EkTMZSqlTCaedlxCTkdlu8gv+vUeR TDm0fr7fhBhAHmQKQHd8N4JrImwZJwQ8xoqIryER9zDOue6QPTVR0dll+ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10658"; a="402317625" X-IronPort-AV: E=Sophos;i="5.98,287,1673942400"; d="scan'208";a="402317625" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2023 02:05:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10658"; a="856804545" X-IronPort-AV: E=Sophos;i="5.98,287,1673942400"; d="scan'208";a="856804545" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 24 Mar 2023 02:05:50 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pfdMq-007q8m-2l; Fri, 24 Mar 2023 11:05:48 +0200 Date: Fri, 24 Mar 2023 11:05:48 +0200 From: Andy Shevchenko To: "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Len Brown Subject: Re: [PATCH v1 2/2] ACPI: SPCR: Amend indentation Message-ID: References: <20230322102258.27390-1-andriy.shevchenko@linux.intel.com> <20230322102258.27390-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 23, 2023 at 09:31:11PM +0100, Rafael J. Wysocki wrote: > On Thu, Mar 23, 2023 at 1:24 PM Andy Shevchenko > wrote: > > On Wed, Mar 22, 2023 at 07:50:55PM +0100, Rafael J. Wysocki wrote: > > > On Wed, Mar 22, 2023 at 11:26 AM Andy Shevchenko > > > wrote: ... > > > > 2) Remove double spaces for consistency. > > > > > > I don't quite agree with this. > > > > > > Double spaces after a period are recognized as end-of-sentence markers > > > by some editors (notably vi), so if they have been used intentionally, > > > I see no reason to replace them. > > > > For the sake of consistency. There places in very same file which do not > > follow this. I can invert and add a space to the rest. Do you prefer that? > > Not really. I just don't think that this is worth the churn. Ah, that's fine. > > The reasoning will be kept the same, though. > > Is the lack of consistency in this particular respect really an issue? > > I guess you can argue that if there are mixed sentence ending styles > in one and the same comment, it is better to make them consistent, > which I can agree with. Otherwise I'm not convinced. Okay, do you agree with the first patch in the series? Then I can redo this one by dropping these particular changes. -- With Best Regards, Andy Shevchenko