From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35731C6FD1D for ; Wed, 15 Mar 2023 16:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232012AbjCOQNY (ORCPT ); Wed, 15 Mar 2023 12:13:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232447AbjCOQNG (ORCPT ); Wed, 15 Mar 2023 12:13:06 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 712946189; Wed, 15 Mar 2023 09:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cCW7axuUfgTUO6O263OSKMwVHUkLkmelwIVXmpc1WJQ=; b=keEczDyeAJz4CTyMgdmjHNLJji tlZVcxG3jY9teZ1rL+FUsyT7ix2zDn23oalr1sEmolShALWOIS3jMo9bzv1d1PE0JNv/r+vF3PdCb otX4eDzoawS8lsC7rMipIc532u55ey7MLVjK9bUCTrgaTS8H9KxkvxbHGqZPoqGZ7kmj2NTlED8lW pSILl7cUhzdL4ANpx1LLPFYTpxcQrawP9FvgP0utshVAzl9AbAYJK1aEDlYvVjAhdW01Ip6FFez7Q lbWZHz55SzIU2dyVkelEWJVmYlX5JR4Cub+sEk95ideeAkpf9uxb1wEUuHEqVZbXU8rygUf90IKva JEQagxlw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pcTjf-00DyaW-BQ; Wed, 15 Mar 2023 16:12:19 +0000 Date: Wed, 15 Mar 2023 16:12:19 +0000 From: Matthew Wilcox To: Peter Zijlstra Cc: Mike Rapoport , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v4 27/36] x86: Implement the new page table range API Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-28-willy@infradead.org> <20230315103436.GA2006103@hirez.programming.kicks-ass.net> <20230315111941.GC2006103@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315111941.GC2006103@hirez.programming.kicks-ass.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 15, 2023 at 12:19:41PM +0100, Peter Zijlstra wrote: > On Wed, Mar 15, 2023 at 01:16:24PM +0200, Mike Rapoport wrote: > > On Wed, Mar 15, 2023 at 11:34:36AM +0100, Peter Zijlstra wrote: > > > On Wed, Mar 15, 2023 at 05:14:35AM +0000, Matthew Wilcox (Oracle) wrote: > > > > Add PFN_PTE_SHIFT and a noop update_mmu_cache_range(). > > > > > > > > Signed-off-by: Matthew Wilcox (Oracle) > > > > Cc: Thomas Gleixner > > > > Cc: Ingo Molnar > > > > Cc: Borislav Petkov > > > > Cc: Dave Hansen > > > > Cc: x86@kernel.org > > > > Cc: "H. Peter Anvin" > > > > --- > > > > arch/x86/include/asm/pgtable.h | 13 ++++++------- > > > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > > > > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > > > > index 1031025730d0..b237878061c4 100644 > > > > --- a/arch/x86/include/asm/pgtable.h > > > > +++ b/arch/x86/include/asm/pgtable.h > > > > @@ -184,6 +184,8 @@ static inline int pte_special(pte_t pte) > > > > > > > > static inline u64 protnone_mask(u64 val); > > > > > > > > +#define PFN_PTE_SHIFT PAGE_SHIFT > > > > + > > > > static inline unsigned long pte_pfn(pte_t pte) > > > > { > > > > phys_addr_t pfn = pte_val(pte); > > > > @@ -1019,13 +1021,6 @@ static inline pud_t native_local_pudp_get_and_clear(pud_t *pudp) > > > > return res; > > > > } > > > > > > > > -static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > > > > - pte_t *ptep, pte_t pte) > > > > -{ > > > > - page_table_check_ptes_set(mm, addr, ptep, pte, 1); > > > > - set_pte(ptep, pte); > > > > -} > > > > - > > > > > > And remove set_pte_at() apparently.. whut?!? > > > > It's now in include/linux/pgtable.h > > All I have is this one patch -- and the changelog doesn't mention this. > HTF am I supposed to know that? You should be subscribed to linux-arch. I literally can't cc all arch maintainers on every patch; many of the mailing lists will reject the emails based on "too many recipients". That's what linux-arch is _for_.