mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
Cc: outreachy@lists.linux.dev, martyn@welchs.me.uk,
	manohar.vanga@gmail.com, zoo868e@gmail.com,
	jerrykang026@gmail.com, cuigaosheng1@huawei.com, arnd@arndb.de,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v4 1/2] staging: vme_user: add space around operators
Date: Thu, 16 Mar 2023 09:49:11 +0100	[thread overview]
Message-ID: <ZBLYB1+4GI1ge6Q8@kroah.com> (raw)
In-Reply-To: <57006c151d4d95550b987143a6650f8b3594ddea.1678899549.git.eng.mennamahmoud.mm@gmail.com>

On Wed, Mar 15, 2023 at 07:00:06PM +0200, Menna Mahmoud wrote:
> Add a space before and after the operator, for readability.
> 
> Reported by checkpatch script:
> 
> " CHECK: spaces preferred around that '+', '<<' and '>>' ".
> 
> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>

This patch, and patch 2/2, do not apply to my staging-next branch at
all.  Are you sure you generated it properly?

Please rebase it and try it again.

thanks,

greg k-h

      parent reply	other threads:[~2023-03-16  8:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15 17:00 Menna Mahmoud
2023-03-15 17:00 ` [PATCH v4 2/2] staging: vme_user: remove unnecessary blank lines Menna Mahmoud
2023-03-16  8:49 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBLYB1+4GI1ge6Q8@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=cuigaosheng1@huawei.com \
    --cc=eng.mennamahmoud.mm@gmail.com \
    --cc=jerrykang026@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=manohar.vanga@gmail.com \
    --cc=martyn@welchs.me.uk \
    --cc=outreachy@lists.linux.dev \
    --cc=zoo868e@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®