From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v1 1/1] regulator: s5m8767: Replace of_gpio.h with what indeed is used
Date: Thu, 16 Mar 2023 15:28:33 +0200 [thread overview]
Message-ID: <ZBMZgSb0FXt7OIJz@smile.fi.intel.com> (raw)
In-Reply-To: <306b94ce-1f45-43a2-ad27-567fa5c235ce@sirena.org.uk>
On Thu, Mar 16, 2023 at 01:10:46PM +0000, Mark Brown wrote:
> On Thu, Mar 16, 2023 at 02:01:13PM +0200, Andy Shevchenko wrote:
> > of_gpio.h in this driver is solely used as a proxy to other headers.
> > This is incorrect usage of the of_gpio.h. Replace it .h with what
> > indeed is used in the code.
>
> This breaks an x86 allmodconfig build:
>
> /build/stage/linux/drivers/regulator/s5m8767.c: In function ‘s5m8767_pmic_dt_parse_dvs_gpio’:
> /build/stage/linux/drivers/regulator/s5m8767.c:492:24: error: implicit declaration of function ‘of_get_named_gpio’ [-Werror=implicit-function-declaration]
> 492 | gpio = of_get_named_gpio(pmic_np,
> | ^~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
Oh, sorry for that. I missed something.
Please, ignore this one, it should be different one.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-03-16 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 12:01 Andy Shevchenko
2023-03-16 13:10 ` Mark Brown
2023-03-16 13:28 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBMZgSb0FXt7OIJz@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®