From: Henrik Grimler <henrik@grimler.se>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
alim.akhtar@samsung.com, m.szyprowski@samsung.com,
jenneron@protonmail.com, markuss.broks@gmail.com,
martin.juecker@gmail.com, virag.david003@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Valentine Iourine <iourine@iourine.msk.su>
Subject: Re: [PATCH v5 2/2] ARM: dts: exynos: add mmc aliases
Date: Sun, 19 Mar 2023 21:13:24 +0100 [thread overview]
Message-ID: <ZBds5NFv1Lr8k0jk@L14.lan> (raw)
In-Reply-To: <216262b8-fe48-6696-17a4-eaa82e776db7@linaro.org>
Hi Krzysztof,
On Fri, Mar 17, 2023 at 01:28:02PM +0100, Krzysztof Kozlowski wrote:
> On 16/03/2023 22:15, Henrik Grimler wrote:
> > Add aliases for eMMC, SD card and WiFi where applicable, so that
> > assigned mmc indeces are always the same.
> >
> > Co-developed-by: Anton Bambura <jenneron@protonmail.com>
> > Signed-off-by: Anton Bambura <jenneron@protonmail.com>
> > [ Tested on exynos5800-peach-pi ]
> > Tested-by: Valentine Iourine <iourine@iourine.msk.su>
> > Signed-off-by: Henrik Grimler <henrik@grimler.se>
> > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> >
>
>
>
> > chosen {
> > diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts
> > index bba85011ecc9..7051e2c4b391 100644
> > --- a/arch/arm/boot/dts/exynos4210-i9100.dts
> > +++ b/arch/arm/boot/dts/exynos4210-i9100.dts
> > @@ -25,6 +25,12 @@ memory@40000000 {
> > reg = <0x40000000 0x40000000>;
> > };
> >
> > + aliases {
> > + mmc0 = &sdhci_0;
> > + mmc2 = &sdhci_2;
> > + mmc3 = &sdhci_3;
>
> Here...
>
> > + };
> > +
> > chosen {
> > stdout-path = "serial2:115200n8";
> > };
> > diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
> > index 1103e7f92b57..1970c31410e5 100644
> > --- a/arch/arm/boot/dts/exynos4210-origen.dts
> > +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> > @@ -30,6 +30,11 @@ memory@40000000 {
> > 0x70000000 0x10000000>;
> > };
> >
> > + aliases {
> > + mmc0 = &sdhci_0;
>
> here ....
>
> > + mmc2 = &sdhci_2;
> > + };
> > +
> > chosen {
> > bootargs = "root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M init=/linuxrc";
> > stdout-path = "serial2:115200n8";
> > diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts b/arch/arm/boot/dts/exynos4210-smdkv310.dts
> > index 181c99eca675..cb74af41e17c 100644
> > --- a/arch/arm/boot/dts/exynos4210-smdkv310.dts
> > +++ b/arch/arm/boot/dts/exynos4210-smdkv310.dts
> > @@ -25,6 +25,10 @@ memory@40000000 {
> > reg = <0x40000000 0x80000000>;
> > };
> >
> > + aliases {
> > + mmc2 = &sdhci_2;
> > + };
> > +
> > chosen {
> > bootargs = "root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M init=/linuxrc";
> > stdout-path = "serial1:115200n8";
> > diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
> > index b8e9dd23fc51..b6b0c116016c 100644
> > --- a/arch/arm/boot/dts/exynos4210-trats.dts
> > +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> > @@ -26,6 +26,12 @@ memory@40000000 {
> > 0x70000000 0x10000000>;
> > };
> >
> > + aliases {
> > + mmc0 = &sdhci_0;
> > + mmc2 = &sdhci_2;
> > + mmc3 = &sdhci_3;
> > + };
> > +
> > chosen {
> > bootargs = "root=/dev/mmcblk0p5 rootwait earlyprintk panic=5";
> > stdout-path = "serial2:115200n8";
> > diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > index 140abfb38e1d..f42cfcbcdcfa 100644
> > --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > @@ -24,6 +24,12 @@ memory@40000000 {
> > 0x50000000 0x10000000>;
> > };
> >
> > + aliases {
> > + mmc0 = &sdhci_0;
> > + mmc2 = &sdhci_2;
>
>
> Why this is 2? Aliases are continues and match the board. For example
> Universal calls this mmc1 and the next mmc2, not 3.
Not sure I follow, Universal calls sdhci_2 mmc1 in schematics? (I have tried searching for
schematics but cannot really find anything about this board)
> I bet it is the same on Trats and all other boards.
Sure, I can change to mmc0, mmc1 for all 4210 devices.
> > + mmc3 = &sdhci_3;
> > + };
> > +
> > chosen {
> > bootargs = "root=/dev/mmcblk0p5 rw rootwait earlyprintk panic=5 maxcpus=1";
> > stdout-path = "serial2:115200n8";
> > diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > index 6260da187e92..0e5419c0eaff 100644
> > --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > @@ -20,6 +20,10 @@ / {
> > model = "TOPEET iTop 4412 Elite board based on Exynos4412";
> > compatible = "topeet,itop4412-elite", "samsung,exynos4412", "samsung,exynos4";
> >
> > + aliases {
> > + mmc2 = &sdhci_2;
>
> mmc1
Ok, will change.
> > + };
> > +
> > chosen {
> > bootargs = "root=/dev/mmcblk0p2 rw rootfstype=ext4 rootdelay=1 rootwait";
> > stdout-path = "serial2:115200n8";
> > diff --git a/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi b/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi
> > index ca8d42b2ce3b..7bc6968af9c3 100644
> > --- a/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi
> > @@ -23,6 +23,10 @@ memory@40000000 {
> > reg = <0x40000000 0x40000000>;
> > };
> >
> > + aliases {
> > + mmc0 = &mshc_0;
> > + };
> > +
> > firmware@203f000 {
> > compatible = "samsung,secure-firmware";
> > reg = <0x0203f000 0x1000>;
> > diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
> > index 82aed59cba7c..e6b949c1a00f 100644
> > --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
> > @@ -25,6 +25,9 @@ / {
> > aliases {
> > i2c11 = &i2c_max77693;
> > i2c12 = &i2c_max77693_fuel;
> > + mmc0 = &mshc_0;
> > + mmc2 = &sdhci_2;
> > + mmc3 = &sdhci_3;
>
> This is actually correct.
>
> > };
> >
> > chosen {
> > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > index 25e082fda955..45ef7b7ba7e0 100644
> > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > @@ -13,6 +13,11 @@
> > #include "exynos-mfc-reserved-memory.dtsi"
> >
> > / {
> > + aliases {
> > + mmc0 = &mshc_0;
> > + mmc2 = &sdhci_2;
>
> This is also correct.
>
> > + };
>
> For all other cases, where schematics are missing, just make them linear.
Alright, will do in next version, thanks for the feedback!
> Krzysztof
Best regards,
Henrik Grimler
next prev parent reply other threads:[~2023-03-19 20:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 21:15 [PATCH v5 0/2] ARM: dts: add mmc aliases for Exynos devices Henrik Grimler
2023-03-16 21:15 ` [PATCH v5 1/2] ARM: dts: exynos: replace mshc0 alias with mmc-ddr-1_8v property Henrik Grimler
2023-03-17 11:55 ` Krzysztof Kozlowski
2023-03-19 20:13 ` Henrik Grimler
2023-03-16 21:15 ` [PATCH v5 2/2] ARM: dts: exynos: add mmc aliases Henrik Grimler
2023-03-17 12:28 ` Krzysztof Kozlowski
2023-03-19 20:13 ` Henrik Grimler [this message]
2023-03-24 11:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBds5NFv1Lr8k0jk@L14.lan \
--to=henrik@grimler.se \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=iourine@iourine.msk.su \
--cc=jenneron@protonmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=markuss.broks@gmail.com \
--cc=martin.juecker@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=virag.david003@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®