From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 166F0C6FD1D for ; Mon, 20 Mar 2023 15:54:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231866AbjCTPyM (ORCPT ); Mon, 20 Mar 2023 11:54:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231479AbjCTPxl (ORCPT ); Mon, 20 Mar 2023 11:53:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33DB94491 for ; Mon, 20 Mar 2023 08:44:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C152C615B5 for ; Mon, 20 Mar 2023 15:44:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D42DBC4339B; Mon, 20 Mar 2023 15:44:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679327078; bh=jVotV7PCuo3EryZ0m72dclvZaKdhsKt6vWYQUGWl+Rg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lIErnD8Dlq7lahLhcQ2DSNbfuMCt3VOzs/F1c769vyiZeqQLydKac4C1Gv/jKwmHF 9gx6TyrE5SWEx9mJumQM9lMc/gatI5rUOBN0rEbwwRje1Q9o/JGq0h+z0R3ZYp39C2 ulsWZO+N4uLWS1inS5KdJg96dWWfP0MeLBLNNGyY= Date: Mon, 20 Mar 2023 16:44:35 +0100 From: Greg KH To: Menna Mahmoud Cc: outreachy@lists.linux.dev, parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, drv@mailo.com, dave@stgolabs.net, yang.lee@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Julia Lawall Subject: Re: [PATCH] staging: most: use inline functions for iface_to_hdm Message-ID: References: <20230320103335.6479-1-eng.mennamahmoud.mm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230320103335.6479-1-eng.mennamahmoud.mm@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 20, 2023 at 12:33:35PM +0200, Menna Mahmoud wrote: > Convert `iface_to_hdm` macro into a static inline function. > it is not great to have macro that use `container_of` macro, > because from looking at the definition one cannot tell > what type it applies to. > > One can get the same benefit from an efficiency point of view > by making an inline function. > > Suggested-by: Julia Lawall > Signed-off-by: Menna Mahmoud > --- > drivers/staging/most/dim2/dim2.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Your subject line has a " " when it should have just a " " :( Please fix up and send a v2. thanks, greg k-h