From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Tom Rix <trix@redhat.com>
Cc: linux@roeck-us.net, gregkh@linuxfoundation.org,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
nathan@kernel.org, ndesaulniers@google.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, llvm@lists.linux.dev
Subject: Re: [PATCH] usb: typec: tcpci_mt6360: remove unused mt6360_tcpc_read16 function
Date: Mon, 20 Mar 2023 13:59:14 +0200 [thread overview]
Message-ID: <ZBhKkqqoSkmBueaO@kuha.fi.intel.com> (raw)
In-Reply-To: <20230319141053.1703937-1-trix@redhat.com>
On Sun, Mar 19, 2023 at 10:10:53AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/usb/typec/tcpm/tcpci_mt6360.c:46:19: error: unused function
> 'mt6360_tcpc_read16' [-Werror,-Wunused-function]
> static inline int mt6360_tcpc_read16(struct regmap *regmap,
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpci_mt6360.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> index 1b7c31278ebb..6fa8fd5c8041 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> @@ -43,12 +43,6 @@ struct mt6360_tcpc_info {
> int irq;
> };
>
> -static inline int mt6360_tcpc_read16(struct regmap *regmap,
> - unsigned int reg, u16 *val)
> -{
> - return regmap_raw_read(regmap, reg, val, sizeof(u16));
> -}
> -
> static inline int mt6360_tcpc_write16(struct regmap *regmap,
> unsigned int reg, u16 val)
> {
> --
> 2.27.0
--
heikki
prev parent reply other threads:[~2023-03-20 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 14:10 Tom Rix
2023-03-20 11:59 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBhKkqqoSkmBueaO@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=llvm@lists.linux.dev \
--cc=matthias.bgg@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®