From: Christoph Hellwig <hch@infradead.org>
To: wuchi <wuchi.zero@gmail.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, ojaswin@linux.ibm.com,
ritesh.list@gmail.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: simplify 32bit calculation of lblk
Date: Tue, 4 Apr 2023 22:40:56 -0700 [thread overview]
Message-ID: <ZC0J6I1pYNZBB30y@infradead.org> (raw)
In-Reply-To: <20230403135304.19858-1-wuchi.zero@gmail.com>
On Mon, Apr 03, 2023 at 09:53:04PM +0800, wuchi wrote:
> - if (block > ext_block)
> - return ext_pblk + (block - ext_block);
> - else
> - return ext_pblk - (ext_block - block);
> + return ext_pblk + ((signed long long)block - (signed long long)ext_block);
And what exactly is the value add here, except for turning an easy
to parse statement into a complex expression using casts?
next prev parent reply other threads:[~2023-04-05 5:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 13:53 wuchi
2023-04-05 5:40 ` Christoph Hellwig [this message]
2023-04-05 8:47 ` chi wu
2023-04-05 11:43 ` David Laight
2023-04-05 12:47 ` chi wu
2023-04-05 13:55 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC0J6I1pYNZBB30y@infradead.org \
--to=hch@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=wuchi.zero@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®