From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 705DAC74A5B for ; Sun, 26 Mar 2023 12:46:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231717AbjCZMq6 (ORCPT ); Sun, 26 Mar 2023 08:46:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229763AbjCZMq4 (ORCPT ); Sun, 26 Mar 2023 08:46:56 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 721197D98 for ; Sun, 26 Mar 2023 05:46:55 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id cn12so25255707edb.4 for ; Sun, 26 Mar 2023 05:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679834814; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rSVPQZLvMg8MxPtgtJhR5Wq1fUwwDFt0dAXT8YpYgaU=; b=iB8dEQPl+YY+fah8Jik5YmwFYZ1C76EJD+O2kEfEkm3OinnmZIBJ1N+GC97dDhRs0K iA7Vj8rZVgRWrxUl+H9jwetFlxrbJUQo+KVJntA3aBgLbtGFbvAMVoDHlysV/RFlbj7Q hzqvDUdZzZy3KZ6wBvgeykVDK4T7NeHKsm6KFhjA7nPc4tOWCWFUsXTbGQO2Gb5twdfx PYA4MQKqwECT/J9+s3A+IBPXDXtiCn08dG4NGunzQwfjiX5BiS2555qz13T+qdUzMeTB JKagAXQcLnz1XIFKSuG0caB4AZBX9c8+AM6PuQlrPllBhZx++zsjdeuybOf/UWZiwy1s CAPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679834814; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rSVPQZLvMg8MxPtgtJhR5Wq1fUwwDFt0dAXT8YpYgaU=; b=OjTGHlqArUxV1B4ag38yUXCWY+LFAEXHnmtiF74gslubGWMWPaAhz5cQr2++VtOU21 qrTpttmsDq5XRQ3FziGp1GhnsP2fhKYEIzdMySqtRRUiBqMWYbJebXotOvOMSiOud+9u KgKsXlTQkZWLAqBuMPLEsHG2aNee3Gfy+hWg8c884HfHoyuhhm5LchkfkCOnUfO8qXrB ObPHt6/LXqSyzXwjWQkd049iCR9qqnFLYflEMUVqiM5XPMTzUD2lL2pVR6UKbDBkll2f rLsE6vtHbA+S6ObzV9iPyTiz94akspxtI6ydcEZ1P4UtREcIqUS2C/fHFe7P/AiGlgRj td4A== X-Gm-Message-State: AAQBX9erV/ACLkoROUeXyBGtrFvFCnHnw0xh5j+/r/EgRX93reMpFPga VKRDfJGzKJnrgOdfJTR8LHM= X-Google-Smtp-Source: AKy350b9q8sglt0xIXc0mxLMsKwZNW2bmLY3U2biBD1vzDSd9YwwZ8EPJNpAnwvcZBW8x8cqNSArrw== X-Received: by 2002:a17:906:fc1e:b0:92b:f3c3:7c5f with SMTP id ov30-20020a170906fc1e00b0092bf3c37c5fmr8581612ejb.53.1679834813916; Sun, 26 Mar 2023 05:46:53 -0700 (PDT) Received: from nam-dell (ip-80-113-101-30.ip.prioritytelecom.net. [80.113.101.30]) by smtp.gmail.com with ESMTPSA id f23-20020a1709064dd700b00931536d461fsm12885452ejw.20.2023.03.26.05.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Mar 2023 05:46:53 -0700 (PDT) Date: Sun, 26 Mar 2023 14:46:52 +0200 From: Nam Cao To: Tom Rix Cc: gregkh@linuxfoundation.org, nathan@kernel.org, ndesaulniers@google.com, artur.bujdoso@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] staging: rtl8723bs: remove unused pHalData variable Message-ID: References: <20230326122321.1352337-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230326122321.1352337-1-trix@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 26, 2023 at 08:23:21AM -0400, Tom Rix wrote: > clang with W=1 reports > drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable > 'pHalData' set but not used [-Werror,-Wunused-but-set-variable] > struct hal_com_data *pHalData; > ^ > This variable is not used so remove it. > > Signed-off-by: Tom Rix > --- > drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c > index e36f8c369a04..0cb2adcc1f78 100644 > --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c > +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c > @@ -1179,10 +1179,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter) > > void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType) > { > - struct hal_com_data *pHalData; > - > - > - pHalData = GET_HAL_DATA(padapter); > } If this function doesn't do anything, does it not make more sense to just remove this function entirely? Best regards, Nam