From: Luis Chamberlain <mcgrof@kernel.org>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: Albert Huang <huangjie.albert@bytedance.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net,
Eric Van Hensbergen <ericvh@gmail.com>,
Christian Schoenebeck <linux_oss@crudebyte.com>
Subject: Re: 9p regression (Was: [PATCH v2] virtio_ring: don't update event idx on get_buf)
Date: Mon, 27 Mar 2023 21:49:40 -0700 [thread overview]
Message-ID: <ZCJx5Dtms5iDhftF@bombadil.infradead.org> (raw)
In-Reply-To: <ZCJNTBQLZeyLBKKB@codewreck.org>
On Tue, Mar 28, 2023 at 11:13:32AM +0900, Dominique Martinet wrote:
> Hi Michael, Albert,
>
> Albert Huang wrote on Sat, Mar 25, 2023 at 06:56:33PM +0800:
> > in virtio_net, if we disable the napi_tx, when we triger a tx interrupt,
> > the vq->event_triggered will be set to true. It will no longer be set to
> > false. Unless we explicitly call virtqueue_enable_cb_delayed or
> > virtqueue_enable_cb_prepare.
>
> This patch (commited as 35395770f803 ("virtio_ring: don't update event
> idx on get_buf") in next-20230327 apparently breaks 9p, as reported by
> Luis in https://lkml.kernel.org/r/ZCI+7Wg5OclSlE8c@bombadil.infradead.org
Spot on, reverting that commit fixes it.
Luis
next prev parent reply other threads:[~2023-03-28 4:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 10:56 [PATCH v2] virtio_ring: don't update event idx on get_buf Albert Huang
2023-03-27 4:02 ` Xuan Zhuo
2023-03-27 12:43 ` Michael S. Tsirkin
2023-03-28 2:13 ` 9p regression (Was: [PATCH v2] virtio_ring: don't update event idx on get_buf) Dominique Martinet
2023-03-28 2:58 ` Jason Wang
2023-03-28 3:09 ` [External] " 黄杰
2023-03-28 3:39 ` Jason Wang
2023-03-28 9:09 ` 黄杰
2023-03-28 14:35 ` Michael S. Tsirkin
2023-03-29 5:34 ` Michael S. Tsirkin
2023-03-29 7:21 ` [PATCH v3] virtio_ring: interrupt disable flag updated to vq even with event_triggered is set Albert Huang
2023-03-29 7:27 ` Xuan Zhuo
2023-03-29 16:28 ` Michael S. Tsirkin
2023-03-29 16:26 ` Michael S. Tsirkin
2023-03-29 5:21 ` [External] Re: 9p regression (Was: [PATCH v2] virtio_ring: don't update event idx on get_buf) Michael S. Tsirkin
2023-03-29 5:42 ` Michael S. Tsirkin
2023-03-30 2:52 ` Jason Wang
2023-03-28 4:49 ` Luis Chamberlain [this message]
2023-03-29 5:36 ` [PATCH v2] virtio_ring: don't update event idx on get_buf Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCJx5Dtms5iDhftF@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=huangjie.albert@bytedance.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=mst@redhat.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®