From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daniel Watson <ozzloy@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: move open curly to first line of if
Date: Tue, 28 Mar 2023 09:56:35 +0200 [thread overview]
Message-ID: <ZCKds6_2QYrZgMXh@kroah.com> (raw)
In-Reply-To: <ZCKYhfonZN36ZHjG@trent-reznor>
On Tue, Mar 28, 2023 at 12:34:29AM -0700, Daniel Watson wrote:
> Checkpatch flagged this as a fixable style error.
What exactly is "this"?
Take a look at the kernel documentation, specifically the file,
Documentation/process/submitting-patches.rst in the section entitled,
"The canonical patch format", for how to write a good subject line, and
changelog text.
Most of the time, that's the hardest part of writing a patch.
Fix that up and send a v2 please (after reading in that same file for
how to properly document that this is a version 2...)
thanks,
greg k-h
prev parent reply other threads:[~2023-03-28 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 7:34 Daniel Watson
2023-03-28 7:56 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCKds6_2QYrZgMXh@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ozzloy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®