From: Luis Chamberlain <mcgrof@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Jan Kara <jack@suse.com>, Yangtao Li <frank.li@vivo.com>,
Arnd Bergmann <arnd@arndb.de>,
Christian Brauner <brauner@kernel.org>,
Seth Forshee <sforshee@digitalocean.com>,
Dave Chinner <dchinner@redhat.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Baokun Li <libaokun1@huawei.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: quota: avoid unused function warning for !CONFIG_SYSCTL
Date: Tue, 28 Mar 2023 10:48:20 -0700 [thread overview]
Message-ID: <ZCMoZMftUgg7Mrv2@bombadil.infradead.org> (raw)
In-Reply-To: <20230328122244.2521387-1-arnd@kernel.org>
On Tue, Mar 28, 2023 at 02:22:31PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> Note: it may be better to just revert the 63d00e08515b patch, as the
> -#ifdef CONFIG_SYSCTL
> - if (!register_sysctl("fs/quota", fs_dqstats_table))
> - pr_notice("quota sysctl registration failed!\n");
> -#endif
> + if (IS_ENABLED(CONFIG_SYSCTL)) {
> + if (!register_sysctl("fs/quota", fs_dqstats_table))
> + pr_notice("quota sysctl registration failed!\n");
> + }
I'd agree to drop that patch and instead just use register_sysctl_init()
iwht Arnd's strategy.
Luis
next prev parent reply other threads:[~2023-03-28 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 12:22 Arnd Bergmann
2023-03-28 17:48 ` Luis Chamberlain [this message]
2023-03-29 9:44 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCMoZMftUgg7Mrv2@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=frank.li@vivo.com \
--cc=jack@suse.com \
--cc=libaokun1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=sforshee@digitalocean.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®