From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
andersson@kernel.org, Thinh.Nguyen@synopsys.com,
gregkh@linuxfoundation.org, mathias.nyman@intel.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/5] arm64: dts: qcom: sc8280xp: Add missing dwc3 quirks
Date: Wed, 29 Mar 2023 14:15:54 +0200 [thread overview]
Message-ID: <ZCQr+hGr/9RQUBK1@hovoldconsulting.com> (raw)
In-Reply-To: <a35bd0e2-b54e-ffa7-e54b-468a3cf77703@linaro.org>
On Wed, Mar 29, 2023 at 01:24:27PM +0200, Konrad Dybcio wrote:
> On 29.03.2023 10:34, Johan Hovold wrote:
> > Perhaps keeping all of these in in the dtsi is correct, but that's going
> > to need some more motivation than simply that some vendor does so (as
> > they often do all sorts of things they should not).
> I'm looking at the DWC3 code and admittedly I don't understand much,
> but is there any harm to keeping them? What if somebody decides to
> plug in a laptop as a gadget device?
We should the add the bits that are really needed with a proper
descriptions of what they do (like all commit messages should).
Besides the commit message, the problem here is that these have just
been copied from some vendor kernel and some properties are conflicting
(e.g. both disabling LPM and configuring LPM settings) while others
appear to be application specific.
Johan
next prev parent reply other threads:[~2023-03-29 12:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 16:52 [PATCH 0/5] usb: dwc3: qcom: Allow runtime PM Manivannan Sadhasivam
2023-03-25 16:52 ` [PATCH 1/5] arm64: dts: qcom: sc8280xp: Add missing dwc3 quirks Manivannan Sadhasivam
2023-03-28 8:54 ` Johan Hovold
2023-03-28 9:38 ` Manivannan Sadhasivam
2023-03-29 5:26 ` Manivannan Sadhasivam
2023-03-29 8:34 ` Johan Hovold
2023-03-29 11:24 ` Konrad Dybcio
2023-03-29 12:15 ` Johan Hovold [this message]
2023-03-29 13:23 ` Manivannan Sadhasivam
2023-04-04 11:25 ` Johan Hovold
2023-03-25 16:52 ` [PATCH 2/5] xhci: host: Use 200ms autosuspend delay for runtime suspend Manivannan Sadhasivam
2023-03-25 16:52 ` [PATCH 3/5] usb: dwc3: qcom: Fix null ptr access during runtime_suspend() Manivannan Sadhasivam
2023-03-28 9:23 ` Johan Hovold
2023-03-28 9:47 ` Manivannan Sadhasivam
2023-03-28 9:51 ` Johan Hovold
2023-03-28 10:08 ` Manivannan Sadhasivam
2023-03-25 16:52 ` [PATCH 4/5] usb: dwc3: qcom: Clear pending interrupt before enabling wake interrupt Manivannan Sadhasivam
2023-03-28 9:28 ` Johan Hovold
2023-03-28 9:50 ` Manivannan Sadhasivam
2023-03-25 16:52 ` [PATCH 5/5] usb: dwc3: qcom: Allow runtime PM Manivannan Sadhasivam
2023-03-28 9:46 ` Johan Hovold
2023-03-28 10:05 ` Manivannan Sadhasivam
2023-03-28 12:18 ` Johan Hovold
2023-03-28 12:57 ` Manivannan Sadhasivam
2023-03-28 13:35 ` Johan Hovold
2023-03-27 9:01 ` [PATCH 0/5] " Konrad Dybcio
2023-03-27 9:17 ` Manivannan Sadhasivam
2023-03-27 9:24 ` Konrad Dybcio
2023-03-27 10:10 ` Manivannan Sadhasivam
2023-03-27 10:33 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCQr+hGr/9RQUBK1@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mathias.nyman@intel.com \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®