mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	Chris Wilson <chris@chris-wilson.co.uk>,
	netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Dmitry Vyukov <dvyukov@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Andi Shyti <andi.shyti@linux.intel.com>
Subject: Re: [PATCH v6 1/8] lib/ref_tracker: add unlocked leak print helper
Date: Wed, 29 Mar 2023 14:35:32 +0200	[thread overview]
Message-ID: <ZCQwlAkAUrtCimj4@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230224-track_gt-v6-1-0dc8601fd02f@intel.com>

Hi Andrzej,

On Wed, Mar 29, 2023 at 09:24:12AM +0200, Andrzej Hajda wrote:
> To have reliable detection of leaks, caller must be able to check under the same
> lock both: tracked counter and the leaks. dir.lock is natural candidate for such
> lock and unlocked print helper can be called with this lock taken.
> As a bonus we can reuse this helper in ref_tracker_dir_exit.
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> 

Thanks,
Andi

  reply	other threads:[~2023-03-29 12:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29  7:24 [PATCH v6 0/8] drm/i915: use ref_tracker library for tracking wakerefs Andrzej Hajda
2023-03-29  7:24 ` [PATCH v6 1/8] lib/ref_tracker: add unlocked leak print helper Andrzej Hajda
2023-03-29 12:35   ` Andi Shyti [this message]
2023-03-29  7:24 ` [PATCH v6 2/8] lib/ref_tracker: improve printing stats Andrzej Hajda
2023-03-29 12:51   ` Andi Shyti
2023-03-29  7:24 ` [PATCH v6 3/8] lib/ref_tracker: add printing to memory buffer Andrzej Hajda
2023-03-29 12:56   ` Andi Shyti
2023-03-29  7:24 ` [PATCH v6 4/8] lib/ref_tracker: remove warnings in case of allocation failure Andrzej Hajda
2023-03-29  7:24 ` [PATCH v6 5/8] drm/i915: Correct type of wakeref variable Andrzej Hajda
2023-03-29  7:24 ` [PATCH v6 6/8] drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library Andrzej Hajda
2023-03-29  7:24 ` [PATCH v6 7/8] drm/i915: track gt pm wakerefs Andrzej Hajda
2023-03-29  7:24 ` [PATCH v6 8/8] drm/i915/gt: Hold a wakeref for the active VM Andrzej Hajda
2023-03-29 13:01 ` [PATCH v6 0/8] drm/i915: use ref_tracker library for tracking wakerefs Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCQwlAkAUrtCimj4@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=davem@davemloft.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dvyukov@google.com \
    --cc=edumazet@google.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®