From: Tejun Heo <tj@kernel.org>
To: Jinke Han <hanjinke.666@bytedance.com>
Cc: josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-throttle: Fix io statistics for cgroup v1
Date: Wed, 29 Mar 2023 08:54:32 -1000 [thread overview]
Message-ID: <ZCSJaBO8i5jQFC10@slm.duckdns.org> (raw)
In-Reply-To: <20230328142309.73413-1-hanjinke.666@bytedance.com>
On Tue, Mar 28, 2023 at 10:23:09PM +0800, Jinke Han wrote:
> From: Jinke Han <hanjinke.666@bytedance.com>
>
> Now the io statistics of cgroup v1 are no longer accurate. Although
> in the long run it's best that rstat is a good implementation of
> cgroup v1 io statistics. But before that, we'd better fix this issue.
Can you please expand on how the stats are wrong on v1 and how the patch
fixes it?
Thanks.
--
tejun
next prev parent reply other threads:[~2023-03-29 18:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 14:23 Jinke Han
2023-03-29 18:54 ` Tejun Heo [this message]
2023-03-30 3:44 ` [External] " hanjinke
2023-03-31 1:44 ` Tejun Heo
2023-03-31 3:00 ` hanjinke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCSJaBO8i5jQFC10@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hanjinke.666@bytedance.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®