From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33159C761A6 for ; Thu, 30 Mar 2023 18:16:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230391AbjC3SQD (ORCPT ); Thu, 30 Mar 2023 14:16:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbjC3SQA (ORCPT ); Thu, 30 Mar 2023 14:16:00 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58BF6EC78 for ; Thu, 30 Mar 2023 11:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NEpKJ7AUMjbrtNaWAPLx1nc4ouGcsx20blnZLkDljQ0=; b=vmOB4pUnsAwl4chabYAiIvENHP iAm/Q6hdG9EiCMzQGu19KvVNjzemGfH99CUK6IIqTKhHMhBlpsJ7uBCCTyyq0oNGzXYkl5ZrHPY/4 G5K8xJCLzu/rxePzsFaeQyhONknjqt2kNtpJ+pecT/ecof+kcIJvRdhBgCDrTyvWxR6giZdmZD1Yv stW1zDLszpQa+QoWV5QInFyZhHnVJq+4aQAhbgAlBUDxbXket/esN9UDLbUhLlue56zI0+RtNY0vT b9REr+6ef9aHRNThfTv+s2rjDW8dJY/g/jLv3MZqxRJRnUVj6vgUhQi+273/RkNQ1UZKQcqzjQ/Hw vdK35UlQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1phwoH-00AeHZ-Rw; Thu, 30 Mar 2023 18:15:41 +0000 Date: Thu, 30 Mar 2023 19:15:41 +0100 From: Matthew Wilcox To: Peng Zhang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, vishal.moola@gmail.com, muchun.song@linux.dev, sidhartha.kumar@oracle.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH v4 5/6] mm: convert copy_user_huge_page() to copy_user_folio() Message-ID: References: <20230330134045.375163-1-zhangpeng362@huawei.com> <20230330134045.375163-6-zhangpeng362@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330134045.375163-6-zhangpeng362@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 30, 2023 at 09:40:44PM +0800, Peng Zhang wrote: > +void copy_user_folio(struct folio *dst, struct folio *src, > + unsigned long addr_hint, > + struct vm_area_struct *vma, > + unsigned int pages_per_huge_page); Do we really want to pass in pages_per_huge_page here? We can get that from folio_nr_pages(dst). > +++ b/mm/hugetlb.c > @@ -5097,8 +5097,8 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src, > ret = PTR_ERR(new_folio); > break; > } > - copy_user_huge_page(&new_folio->page, ptepage, addr, dst_vma, > - npages); > + copy_user_folio(new_folio, page_folio(ptepage), addr, dst_vma, > + npages); > put_page(ptepage); This function should be converted to s/ptepage/pte_folio/, but that's not for this patch series. > - copy_user_huge_page(&new_folio->page, old_page, address, vma, > - pages_per_huge_page(h)); > + copy_user_folio(new_folio, page_folio(old_page), address, vma, > + pages_per_huge_page(h)); Likewise for s/old_page/old_folio/