From: Herbert Xu <herbert@gondor.apana.org.au>
To: David Yang <mmyangfl@gmail.com>
Cc: linux-crypto@vger.kernel.org, Weili Qian <qianweili@huawei.com>,
Zhou Wang <wangzhou1@hisilicon.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] crypto: hisilicon/trng - add support for HiSTB TRNG
Date: Sat, 1 Apr 2023 16:06:34 +0800 [thread overview]
Message-ID: <ZCfmCmxobIKaBdT4@gondor.apana.org.au> (raw)
In-Reply-To: <20230331101943.831347-1-mmyangfl@gmail.com>
On Fri, Mar 31, 2023 at 06:19:34PM +0800, David Yang wrote:
>
> + struct histb_trng_priv *priv = (struct histb_trng_priv *) rng->priv;
Plesae don't use rng->priv at all. We're trying to phase it
out because it encourages horrible casting like this.
Please follow the model used in the meson driver.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-04-01 8:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 10:19 David Yang
2023-04-01 8:06 ` Herbert Xu [this message]
2023-04-01 14:05 ` Yangfl
2023-04-03 4:18 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCfmCmxobIKaBdT4@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=qianweili@huawei.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®