From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8908C7619A for ; Sun, 2 Apr 2023 06:47:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbjDBGrv (ORCPT ); Sun, 2 Apr 2023 02:47:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjDBGrt (ORCPT ); Sun, 2 Apr 2023 02:47:49 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A8D81882D; Sat, 1 Apr 2023 23:47:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680418068; x=1711954068; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ILD5aDX4xRvk1GomwpsChYpGWYmYGxotq3yjh2CxP9E=; b=Un53VBcktewywafeNbNX0poDZ6J/sEuEecQcjpVwlMoW7Roa/XidHQX1 u1umG/zUJgtPnAE1Zy+jSnL+Ppib4i5vGA26SE+uEaJkj4Lh5vf+Er5sC kDGq3D7hjLlnIYj0hyDHr/XEXDZDii9T7vW4zjtpugHruCbO+TS1djIWO lLI7PzUOSlHwB/MJ0p4fW6qxnfd3lrXfNJ7ZzJy3VawlwFV35Kx9YAMBu I3w1imjDsVU3j3hpAnNEnzNYkYY2l70Zj4gH3d2VGnPcNEGH2SCnTcuxa PmgDsLHApb5NaR/F9NT0muoPo2jZnmh74Oleg+5BRB220wDv7EoSx/6os w==; X-IronPort-AV: E=McAfee;i="6600,9927,10667"; a="325706286" X-IronPort-AV: E=Sophos;i="5.98,312,1673942400"; d="scan'208";a="325706286" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2023 23:47:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10667"; a="662839893" X-IronPort-AV: E=Sophos;i="5.98,312,1673942400"; d="scan'208";a="662839893" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by orsmga006.jf.intel.com with ESMTP; 01 Apr 2023 23:47:45 -0700 Date: Sun, 2 Apr 2023 14:36:09 +0800 From: Xu Yilun To: Marco Pagani Cc: Moritz Fischer , Wu Hao , Tom Rix , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fpga: bridge: fix kernel-doc Message-ID: References: <20230330174505.158920-1-marpagan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330174505.158920-1-marpagan@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-03-30 at 19:45:05 +0200, Marco Pagani wrote: > Fix the following warnings issued by the kernel-doc script: > > drivers/fpga/fpga-bridge.c:99: warning: No description found for return value of 'of_fpga_bridge_get' > drivers/fpga/fpga-bridge.c:163: warning: No description found for return value of 'fpga_bridges_enable' > drivers/fpga/fpga-bridge.c:187: warning: No description found for return value of 'fpga_bridges_disable' > drivers/fpga/fpga-bridge.c:238: warning: No description found for return value of 'of_fpga_bridge_get_to_list' > drivers/fpga/fpga-bridge.c:268: warning: No description found for return value of 'fpga_bridge_get_to_list' I see you are trying to clean up the warnings, but I found more in drivers/fpga. Could you help at least fix all core code, (of-)fpga-bridge/region/mgr.c/h in series? Thanks. > > The patch is based on top of 38dbcd697770 ("fpga: bridge: fix kernel-doc parameter description"). I didn't found this commit, could you elaborate? And you could put this info in changelog, don't show it up in mainline. Thanks, Yilun