From: Petr Mladek <pmladek@suse.com>
To: Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>
Cc: Stanislav Kinsburskii <stanislav.kinsburski@gmail.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Remove obsoleted check for non-existent "user" object
Date: Mon, 3 Apr 2023 12:41:02 +0200 [thread overview]
Message-ID: <ZCqtPhbsEJgDAtgc@alley> (raw)
In-Reply-To: <167929571877.2810.9926967619100618792.stgit@skinsburskii.localdomain>
On Mon 2023-03-20 00:02:01, Stanislav Kinsburskii wrote:
> From: Stanislav Kinsburskii <stanislav.kinsburski@gmail.com>
>
> The original check for non-null "user" object was introduced by commit
> e11fea92e13f ("kmsg: export printk records to the /dev/kmsg interface") when
> "user" could be NULL if /dev/ksmg was opened for writing.
>
> Subsequent change 750afe7babd1 ("printk: add kernel parameter to control
> writes to /dev/kmsg") made "user" context required for files opened for write,
> but didn't remove now redundant checks for it to be non-NULL.
>
> This patch removes the dead code while preserving the current logic.
>
> Signed-off-by: Stanislav Kinsburskii <stanislav.kinsburski@gmail.com>
JFYI, the patch has been committed into, printk/linux.git,
branch for-6.4.
Best Regards,
Petr
prev parent reply other threads:[~2023-04-03 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 7:02 Stanislav Kinsburskii
2023-03-31 4:05 ` Sergey Senozhatsky
2023-04-03 9:59 ` Petr Mladek
2023-04-03 10:41 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCqtPhbsEJgDAtgc@alley \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=skinsburskii@linux.microsoft.com \
--cc=stanislav.kinsburski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®