From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96564C76188 for ; Mon, 3 Apr 2023 14:53:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234258AbjDCOxo (ORCPT ); Mon, 3 Apr 2023 10:53:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234106AbjDCOxa (ORCPT ); Mon, 3 Apr 2023 10:53:30 -0400 Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 749F9113CC for ; Mon, 3 Apr 2023 07:53:00 -0700 (PDT) Received: by mail-qv1-xf2d.google.com with SMTP id on15so8012807qvb.7 for ; Mon, 03 Apr 2023 07:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1680533579; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PUO/KjMRf7ccJa58/ksmOm78AxORGxzl+O/+LUACmVM=; b=iEQPySr4AvS2/y19Q8XQChnc8kEE6OKeQBoO/ux+vRpC4bSqWh9jxf646NwjiGwl0c +P1SkvpwR8fp03ZQfQjoDOMsJs2mWhSAGOwBrAj39YVwLGScCRdb6VM8mRSnG3vSP+mf 5hWNcXFejUK1jETlnB2WXyq26k5DUY3rz4kb2DfwMuQgT7w8sInyi5LB7rneB/hrj3vt uC7q+rqPfn/azR5QPx5J5tdH+stdF37ftRkf69idQZQlKNGBhAd6Wm/MYh5c8TwyU+3l 8eBqbEIX+6M5AJHR2RDda2+PmjjQxuBQi3MsQf48HEjOVxTDu/BkpEtJBbwot6EG19j0 W+2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680533579; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PUO/KjMRf7ccJa58/ksmOm78AxORGxzl+O/+LUACmVM=; b=xakyQ3/gqAMJele3Vt1SzOAl4+Ej0/ArRGOshbisDmHte8sLzvNd2E95SL8zQr5kxH i7GFbtsm/3wcbLCnXV3EPzd/a37eCrI/hKg8oo/di4v5RwPvghAZjgaWjlwzrQaAZmod EJRHsMn4Yr+91/WhoVi5yu+8pWKkBsIvWNJjuUh/Wuf67lRR/u8yD2NcAf9BndpSVrhE lO7wN49f/Tux0WILZnt+QgCihI+lkSOTj87JTdXZ4R6kiq/rUsrrd6uboGWtzdTogP3K 0e4UM5EhQ7cB4j5lJKwsRSiXcqTJnvS4ZKRX/zlVOJsK2+R8su30xmYmu7mg/IN1NYy6 7Wjw== X-Gm-Message-State: AAQBX9cYGmzcTZkNbtPsfIYnSmNalwWPbPvIeUVxmFevq8jK3pTjIUMf bnE7Uy558da+SK0WrU4ws/7idElbGVheVdRRzvw= X-Google-Smtp-Source: AKy350Z/o+tPlLNvTbsM001xQWI9G0TJ9RcF3+LkMsE21GwUwGyBHbbQjAvEWF7Lm/ODUr1cvcHuZQ== X-Received: by 2002:a05:6214:2528:b0:537:6416:fc2b with SMTP id gg8-20020a056214252800b005376416fc2bmr63124779qvb.52.1680533579550; Mon, 03 Apr 2023 07:52:59 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-25-194.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.25.194]) by smtp.gmail.com with ESMTPSA id z7-20020a0cf007000000b005e3d3cafc16sm211260qvk.73.2023.04.03.07.52.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 07:52:59 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1pjLYI-006MBH-Bu; Mon, 03 Apr 2023 11:52:58 -0300 Date: Mon, 3 Apr 2023 11:52:58 -0300 From: Jason Gunthorpe To: Steven Price Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Hellstrom , Christoph Hellwig , kernel test robot Subject: Re: [PATCH] smaps: Fix defined but not used smaps_shmem_walk_ops Message-ID: References: <20230403111255.141623-1-steven.price@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403111255.141623-1-steven.price@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 03, 2023 at 12:12:55PM +0100, Steven Price wrote: > When !CONFIG_SHMEM smaps_shmem_walk_ops is defined but not used, > triggering a compiler warning. Surround the definition with an #ifdef to > keep the compiler happy. > > Fixes: 7b86ac3371b7 ("pagewalk: separate function pointers from iterator data") > Reported-by: kernel test robot > Link: https://lore.kernel.org/oe-kbuild-all/202304031749.UiyJpxzF-lkp@intel.com/ > Signed-off-by: Steven Price > --- > fs/proc/task_mmu.c | 2 ++ > 1 file changed, 2 insertions(+) I think it would be better to enclose the definition of shmem_swap_usage() in its header with a stub like shmem_mapping and remove the ifdef completely. shmem_mapping() is already compile time false. #ifdef CONFIG_SHMEM if (vma->vm_file && shmem_mapping(vma->vm_file->f_mapping)) { /* * For shared or readonly shmem mappings we know that all * swapped out pages belong to the shmem object, and we can * obtain the swap value much more efficiently. For private * writable mappings, we might have COW pages that are * not affected by the parent swapped out pages of the shmem * object, so we have to distinguish them during the page walk. * Unless we know that the shmem object (or the part mapped by * our VMA) has no swapped out pages at all. */ unsigned long shmem_swapped = shmem_swap_usage(vma); if (!start && (!shmem_swapped || (vma->vm_flags & VM_SHARED) || !(vma->vm_flags & VM_WRITE))) { mss->swap += shmem_swapped; } else { ops = &smaps_shmem_walk_ops; } } #endif Jason