From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77668C77B60 for ; Tue, 4 Apr 2023 16:30:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234931AbjDDQaC (ORCPT ); Tue, 4 Apr 2023 12:30:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233810AbjDDQaA (ORCPT ); Tue, 4 Apr 2023 12:30:00 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BD6EE7A for ; Tue, 4 Apr 2023 09:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680625799; x=1712161799; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Ad2yLR2QGHM1zH+wT1W70rZoVZagkqBkiUabciymSJQ=; b=XE+oN4eSAkek9k3mdiHgbbbfhKXhb7qnOZ3XLl8GvcPT/c3IzjkWqO1L ekDGBnk4neV4XBYfNk7p27RR2mWXdTxQN9Je82lTLCGGTrZMm0GmFhPqp EcXHqN0mh/yr6WDZrr5+p3mo44gzhUOCdP1CE8Td4LbtmLgJYjzsRsw5a 170I0nZVx8WPaKXQYTC4xKuFbFK+EoMVxmBhRCnkkqTTj/VmBSj/G8bBE ZZr8xONvWAjYBQkibBBKDLk13tZYl49LuJ/vV6dhIrTeh4zueSU65Z5M0 Ga91ngBRg3WuKPTXQgI0WIRDsJVMx7uen+kuRL98umoFkS+4x8hDRO9vu g==; X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="428523952" X-IronPort-AV: E=Sophos;i="5.98,318,1673942400"; d="scan'208";a="428523952" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2023 09:29:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="775709901" X-IronPort-AV: E=Sophos;i="5.98,318,1673942400"; d="scan'208";a="775709901" Received: from vferra-mobl1.ger.corp.intel.com (HELO intel.com) ([10.252.53.196]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2023 09:29:54 -0700 Date: Tue, 4 Apr 2023 18:29:26 +0200 From: Andi Shyti To: Andrzej Hajda Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chris Wilson , Andi Shyti , Chris Wilson Subject: Re: [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM Message-ID: References: <20230330-hold_wakeref_for_active_vm-v2-1-724d201499c2@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330-hold_wakeref_for_active_vm-v2-1-724d201499c2@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Mar 31, 2023 at 04:16:36PM +0200, Andrzej Hajda wrote: > From: Chris Wilson > > There may be a disconnect between the GT used by the engine and the GT > used for the VM, requiring us to hold a wakeref on both while the GPU is > active with this request. > > v2: added explanation to __queue_and_release_pm > > Signed-off-by: Chris Wilson > [ahajda: removed not-yet-upstremed wakeref tracking bits] > Signed-off-by: Andrzej Hajda Thank you Tvrtko and Chris for answering my questions, Reviewed-by: Andi Shyti Andi