From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D754DC77B72 for ; Mon, 17 Apr 2023 10:46:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230171AbjDQKqL (ORCPT ); Mon, 17 Apr 2023 06:46:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbjDQKqG (ORCPT ); Mon, 17 Apr 2023 06:46:06 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDFED49DD; Mon, 17 Apr 2023 03:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681728309; x=1713264309; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Q0LVjKHHmuRFdXP0gH1A8hWP0FnpGL5CdzUawYKr0oI=; b=Lj9NEl1/XaADKEMIENvl+tUwF2XAJKszIlIsMZHyZ/VtsfR7HvQewVjx gWMcK7CrgK1vdjMUyZIlco0Hcv+P2VoPcK/L1ZPKT7iDKPGrR+uNS+bow WSaUNLIxkJIFi3iS9IukI0pCHkSqiQVBjcChfJdQrXE0alR3T23MbWsVv sfBW7T2Wf3J/Ee/a+Srx+6QpZy16ImE/9CTk74/AnNXjmpF613lNpT4fj jBGdrRfkmFwnd7W99pJgqGhEXKF8tswwBDcxkx3nOEhQcYezcJT0J7YV4 C5amkMeLNV14DRYV+dVmpigkZAHppNMG9LruzGav6o7uDvhl5bxgVbdjR w==; X-IronPort-AV: E=McAfee;i="6600,9927,10682"; a="342352606" X-IronPort-AV: E=Sophos;i="5.99,203,1677571200"; d="scan'208";a="342352606" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2023 03:43:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10682"; a="759909509" X-IronPort-AV: E=Sophos;i="5.99,203,1677571200"; d="scan'208";a="759909509" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 17 Apr 2023 03:43:22 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1poMKQ-0012vq-0a; Mon, 17 Apr 2023 13:43:22 +0300 Date: Mon, 17 Apr 2023 13:43:21 +0300 From: Andy Shevchenko To: Joy Chakraborty Cc: Serge Semin , Mark Brown , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, manugautam@google.com, rohitner@google.com Subject: Re: [PATCH v6 2/5] spi: dw: Move "dw_spi_can_dma" function Message-ID: References: <20230414120520.360291-1-joychakr@google.com> <20230414120520.360291-3-joychakr@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230414120520.360291-3-joychakr@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 14, 2023 at 12:05:17PM +0000, Joy Chakraborty wrote: > Move "dw_spi_can_dma" function implementation below > "dw_spi_dma_convert_width" function for handing compile dependency in > future patches. We refer to the functions like func(). ... > +static bool dw_spi_can_dma(struct spi_controller *master, > + struct spi_device *spi, struct spi_transfer *xfer) > +{ > + struct dw_spi *dws = spi_controller_get_devdata(master); > + > + return xfer->len > dws->fifo_len; > +} > + > + Single blank line is enough. -- With Best Regards, Andy Shevchenko