From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A766CC77B70 for ; Mon, 10 Apr 2023 13:52:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229792AbjDJNwM (ORCPT ); Mon, 10 Apr 2023 09:52:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjDJNwL (ORCPT ); Mon, 10 Apr 2023 09:52:11 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5495A49ED for ; Mon, 10 Apr 2023 06:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xJiy5asiUhmQxlHjXRXu9kHZp3LovZa44g8LjX7RzaE=; b=LSDK9hfvS470b8r0sjcgHolIMj fjCO4XrBHUI/jZPzk6H8Q4gmgsTnOtsF9aD/E+O4cU40BzunkQ2U69NHqeZlByju5NkjbZfN7VvW+ j5cfaeW+UKixZKr1urBwdEAaU+go2YbR8FWZlyZ/71SlUYqN73b3hzdnIY350Mtp+tFj+DYVNclxh M40l1YLgmdA2ThhJpXWz9CgSZz8XaeTUp6h1Xbhbei1VYLnUvwmZNa7ELmZ62x0RGWEerRI1X48IS CswZJETP5FiBxshp7iZsk0BbLSa63VfwK4zSxWZ79M89ko/LT2tzY0ErJzcD7zVrJ/FHTpNMMuQjB 0NF4pJQA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1plrvw-004E8M-AG; Mon, 10 Apr 2023 13:51:48 +0000 Date: Mon, 10 Apr 2023 14:51:48 +0100 From: Matthew Wilcox To: Peng Zhang Cc: Gang Li , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, David Binderman Subject: Re: [PATCH] maple_tree: Use correct variable type in sizeof Message-ID: References: <20230410091431.74961-1-zhangpeng.00@bytedance.com> <8b5af22d-1612-a2a0-02da-728f1fd57bf1@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 10, 2023 at 06:09:27PM +0800, Peng Zhang wrote: > Maybe sizeof(void *) is equal to sizeof(unsigned long) > in most architectures, so I don't know if it counts as a fix. This is actually required inside the Linux kernel. The only programming model I know where sizeof(void *) != sizeof(unsigned long) is Windows 64-bit userspace.