From: Alison Schofield <alison.schofield@intel.com>
To: Sumitra Sharma <sumitraartsy@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Fix logical operator continuations
Date: Mon, 10 Apr 2023 17:07:12 -0700 [thread overview]
Message-ID: <ZDSksGyxnu5eIo+1@aschofie-mobl2> (raw)
In-Reply-To: <20230408171803.GA262580@sumitra.com>
On Sat, Apr 08, 2023 at 10:18:03AM -0700, Sumitra Sharma wrote:
> Fix logical operator continuation as suggested by Linux kernel
> coding-style. Check reported by checkpatch:
>
> CHECK: Logical continuations should be on the previous line
>
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
Hi Sumitra,
That commit message can be explicit, like "Move logical operator
to previous line"
Alison
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> index 5a1cd22f5e25..58ed394202ae 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> @@ -209,8 +209,8 @@ void rtl92e_leisure_ps_enter(struct net_device *dev)
> &priv->rtllib->pwr_save_ctrl;
>
> if (!((priv->rtllib->iw_mode == IW_MODE_INFRA) &&
> - (priv->rtllib->state == RTLLIB_LINKED))
> - || (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
> + (priv->rtllib->state == RTLLIB_LINKED)) ||
> + (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
> (priv->rtllib->iw_mode == IW_MODE_MASTER))
> return;
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-04-11 0:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 17:18 Sumitra Sharma
2023-04-11 0:07 ` Alison Schofield [this message]
2023-04-11 5:32 ` Sumitra Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDSksGyxnu5eIo+1@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sumitraartsy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®