From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Michael Riesch <michael.riesch@wolfvision.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Michael Riesch via B4 Relay
<devnull+michael.riesch.wolfvision.net@kernel.org>,
linux-kernel@vger.kernel.org,
Matthias Fend <Matthias.Fend@wolfvision.net>,
libcamera-devel@lists.libcamera.org, linux-media@vger.kernel.org
Subject: Re: [libcamera-devel] [PATCH RFC 1/4] media: v4l2-ctrls: add lens group status controls for zoom and focus
Date: Wed, 12 Apr 2023 18:12:19 +0300 [thread overview]
Message-ID: <ZDbKU5kwcb7RGeCo@kekkonen.localdomain> (raw)
In-Reply-To: <CAPY8ntCNuvgmF37kDvVh1kuepbLqy2hWcz9HOi8iub9trHmi2g@mail.gmail.com>
Hi Dave, Michael,
On Wed, Apr 12, 2023 at 02:55:56PM +0100, Dave Stevenson wrote:
> > > If the ranges aren't updated, where should that out-of-range lens
> > > movement leave the lens?
> >
> > This is up to the hardware controller, but I would guess it typically
> > stops one step before disaster. Wherever that may be, the error
> > condition and the current position can be read out via this new STATUS
> > control.
> >
> > Does this sound good so far?
>
> Sounds reasonable, but I'm not the gatekeeper (that would be Sakari or
> Laurent), and I'm just expressing my views based on the lenses I've
> encountered.
> All of my lenses have a single drive for focus, a single drive for
> zoom, and where there are multiple elements they are all connected
> mechanically. Your setup sounds far more complex and is likely to need
> a more extensive driver, but it'd be nice to not unnecessarily
> overcomplicate the interface.
Could we also have a driver that uses these new controls?
The controls themselves appear reasonable to me as well. I guess there are
changes to be made based on the discussion?
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2023-04-12 15:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 14:31 [PATCH RFC 0/4] media: v4l2-ctrls: add controls for complex lens controller devices Michael Riesch via B4 Relay
2023-04-06 14:31 ` [PATCH RFC 1/4] media: v4l2-ctrls: add lens group status controls for zoom and focus Michael Riesch via B4 Relay
2023-04-06 15:16 ` [libcamera-devel] " Dave Stevenson
2023-04-11 17:33 ` Michael Riesch
2023-04-11 18:15 ` Dave Stevenson
2023-04-12 8:00 ` Michael Riesch
2023-04-12 11:50 ` Sakari Ailus
2023-04-12 11:57 ` Michael Riesch
2023-04-12 12:05 ` Sakari Ailus
2023-04-12 13:43 ` Michael Riesch
2023-04-12 14:39 ` Sakari Ailus
2023-04-12 14:57 ` Dave Stevenson
2023-04-12 13:55 ` Dave Stevenson
2023-04-12 15:12 ` Sakari Ailus [this message]
2023-04-17 12:38 ` Michael Riesch
2023-04-19 9:01 ` Sakari Ailus
2023-04-19 11:24 ` Michael Riesch
2023-04-19 12:49 ` Dave Stevenson
2023-04-24 19:57 ` Sakari Ailus
2023-04-17 8:29 ` Michael Riesch
2023-04-06 14:31 ` [PATCH RFC 2/4] media: v4l2-ctrls: add lens group speed " Michael Riesch via B4 Relay
2023-04-06 14:31 ` [PATCH RFC 3/4] media: v4l2-ctrls: add lens calibration controls Michael Riesch via B4 Relay
2023-04-06 14:31 ` [PATCH RFC 4/4] media: v4l2-ctrls: add controls for individual zoom lenses Michael Riesch via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDbKU5kwcb7RGeCo@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=Matthias.Fend@wolfvision.net \
--cc=dave.stevenson@raspberrypi.com \
--cc=devnull+michael.riesch.wolfvision.net@kernel.org \
--cc=libcamera-devel@lists.libcamera.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michael.riesch@wolfvision.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®