From: Yujie Liu <yujie.liu@intel.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: kernel test robot <lkp@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
<oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<linux-acpi@vger.kernel.org>
Subject: Re: drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size
Date: Thu, 13 Apr 2023 09:54:26 +0800 [thread overview]
Message-ID: <ZDdg0hfJQeQh/2SZ@yujie-X299> (raw)
In-Reply-To: <ZDVA8ykiKaXSzJdM@arm.com>
On Tue, Apr 11, 2023 at 12:13:55PM +0100, Catalin Marinas wrote:
> On Fri, Apr 07, 2023 at 03:02:15PM +0800, kernel test robot wrote:
> > FYI, the error/warning still remains.
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: f2afccfefe7be1f7346564fe619277110d341f9b
> > commit: 8f9e0a52810dd83406c768972d022c37e7a18f1f ACPI: Don't build ACPICA with '-Os'
> > date: 2 months ago
> > config: x86_64-sof-customedconfig-fuzz-defconfig (https://download.01.org/0day-ci/archive/20230407/202304071552.CeeIBr5P-lkp@intel.com/config)
> > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> > reproduce (this is a W=1 build):
> > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8f9e0a52810dd83406c768972d022c37e7a18f1f
> > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > git fetch --no-tags linus master
> > git checkout 8f9e0a52810dd83406c768972d022c37e7a18f1f
> > # save the config file
> > mkdir build_dir && cp config build_dir/.config
> > make W=1 O=build_dir ARCH=x86_64 olddefconfig
> > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Link: https://lore.kernel.org/oe-kbuild-all/202304071552.CeeIBr5P-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/acpi/acpica/tbfind.c: In function 'acpi_tb_find_table':
> > >> drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size [-Werror=stringop-truncation]
> > 60 | strncpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/acpi/acpica/tbfind.c:61:9: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation]
> > 61 | strncpy(header.oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
>
> I think the kernel test robot should filter out any reports related to
> this commit. The warning has nothing to do with the -O2 vs -Os change.
> It's simply that the compiler now warns if strncpy() has the destination
> size equal to the bound parameter (for some reason it doesn't do this
> with -Os). I mentioned it on a different report here:
>
> https://lore.kernel.org/all/Y%2FdM77YdzDKRDdj1@arm.com/
>
> A potential solution to silence the compiler is to go through the ACPI
> code and change those strncpy() instances to memcpy(). I don't think
> those strings are even null-terminated in the APCI spec, so using
> strncpy() doesn't make sense.
Sorry for making this noise. We've configured the robot to filter out
the reports related to this commit.
--
Best Regards,
Yujie
next prev parent reply other threads:[~2023-04-13 1:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 7:02 kernel test robot
2023-04-11 11:13 ` Catalin Marinas
2023-04-13 1:54 ` Yujie Liu [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-23 1:25 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDdg0hfJQeQh/2SZ@yujie-X299 \
--to=yujie.liu@intel.com \
--cc=catalin.marinas@arm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®