From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81E78C77B6F for ; Fri, 14 Apr 2023 11:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230341AbjDNLBW (ORCPT ); Fri, 14 Apr 2023 07:01:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230019AbjDNLBN (ORCPT ); Fri, 14 Apr 2023 07:01:13 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9B00E49FF for ; Fri, 14 Apr 2023 04:01:12 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B8DA82F4; Fri, 14 Apr 2023 04:01:56 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.21.222]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AD91B3F587; Fri, 14 Apr 2023 04:01:10 -0700 (PDT) Date: Fri, 14 Apr 2023 12:01:07 +0100 From: Mark Rutland To: Johan Hovold , Arnd Bergmann Cc: Lorenzo Pieralisi , Ulf Hansson , Dmitry Baryshkov , Sudeep Holla , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v2] firmware/psci: demote suspend-mode warning to info level Message-ID: References: <20230414084619.31524-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230414084619.31524-1-johan+linaro@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 14, 2023 at 10:46:19AM +0200, Johan Hovold wrote: > On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode > during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb > ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this > is now logged at warning level: > > psci: failed to set PC mode: -3 > > As there is nothing users can do about the firmware behaving this way, > demote the warning to info level and clearly mark it as a firmware bug: > > psci: [Firmware Bug]: failed to set PC mode: -3 > > Reviewed-by: Ulf Hansson > Acked-by: Mark Rutland > Acked-by: Sudeep Holla > Signed-off-by: Johan Hovold > --- > > This one fell between the cracks so resending with tags added. > > Mark or Lorenzo, is this something you can pick up? > > Johan Sorry about this. I don't think we have anything else in this area, so Arnd, are you happy to pick this via the soc tree? Thanks, Mark. > > > drivers/firmware/psci/psci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index 29619f49873a..d9629ff87861 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -167,7 +167,8 @@ int psci_set_osi_mode(bool enable) > > err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); > if (err < 0) > - pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); > + pr_info(FW_BUG "failed to set %s mode: %d\n", > + enable ? "OSI" : "PC", err); > return psci_to_linux_errno(err); > } > > -- > 2.39.2 >