From: Michal Hocko <mhocko@suse.com>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: hannes@cmpxchg.org, vbabka@suse.cz, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/show_mem.c: Use for_each_populated_zone() simplify code
Date: Mon, 17 Apr 2023 09:52:46 +0200 [thread overview]
Message-ID: <ZDz6znEFRp6JwvVN@dhcp22.suse.cz> (raw)
In-Reply-To: <20230417035226.4013584-1-yajun.deng@linux.dev>
On Mon 17-04-23 11:52:26, Yajun Deng wrote:
> The __show_mem() needs to iterate over all zones that have memory, we can
> simplify the code by using for_each_populated_zone().
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
> ---
> lib/show_mem.c | 19 ++++++-------------
> 1 file changed, 6 insertions(+), 13 deletions(-)
>
> diff --git a/lib/show_mem.c b/lib/show_mem.c
> index 0d7585cde2a6..1485c87be935 100644
> --- a/lib/show_mem.c
> +++ b/lib/show_mem.c
> @@ -10,26 +10,19 @@
>
> void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)
> {
> - pg_data_t *pgdat;
> unsigned long total = 0, reserved = 0, highmem = 0;
> + struct zone *zone;
>
> printk("Mem-Info:\n");
> __show_free_areas(filter, nodemask, max_zone_idx);
>
> - for_each_online_pgdat(pgdat) {
> - int zoneid;
> + for_each_populated_zone(zone) {
>
> - for (zoneid = 0; zoneid < MAX_NR_ZONES; zoneid++) {
> - struct zone *zone = &pgdat->node_zones[zoneid];
> - if (!populated_zone(zone))
> - continue;
> + total += zone->present_pages;
> + reserved += zone->present_pages - zone_managed_pages(zone);
>
> - total += zone->present_pages;
> - reserved += zone->present_pages - zone_managed_pages(zone);
> -
> - if (is_highmem_idx(zoneid))
> - highmem += zone->present_pages;
> - }
> + if (is_highmem(zone))
> + highmem += zone->present_pages;
> }
>
> printk("%lu pages RAM\n", total);
> --
> 2.25.1
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2023-04-17 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 3:52 Yajun Deng
2023-04-17 7:27 ` Vlastimil Babka
2023-04-17 7:52 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDz6znEFRp6JwvVN@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vbabka@suse.cz \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®