From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7940C77B75 for ; Fri, 21 Apr 2023 06:29:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229869AbjDUG3C (ORCPT ); Fri, 21 Apr 2023 02:29:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbjDUG3A (ORCPT ); Fri, 21 Apr 2023 02:29:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E035420B for ; Thu, 20 Apr 2023 23:28:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE67F64E06 for ; Fri, 21 Apr 2023 06:28:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34A3AC433EF; Fri, 21 Apr 2023 06:28:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682058535; bh=fDzyTwqwYy1p3E1HPlBerUNEVhCJC25uaFNzEjHZIpo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SGjhVfixPmGjuaAJVvku0cH3xNGa38Gx0ysu7qeDMkzf7dJ1rGglsr0vKFF2BpHqT GPgAZwgmY6v6+sekGp8RoiP5A5IZQgTg68avEKyX06/daqD+xvRmRHV9SANnXofIbg XLKgHXj8z4HiPXKw4t11dg7XWgRwMXph6ER1SmqEGPS76CNgYV39aapQZntVbMJSpv 1pqRqcrQzR2tm4EsOigXsoOIpUk1aVQi1+0YjG17t949/efhcVUHLtuW788Hwo2tjE h+FVTzbVyS1DitCtuTXnLvkfm82ugcNhO29085r18rC7vGkNr3ORCUcn3z52CzOJd7 +iOcbApRk332w== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1ppkGc-000659-JO; Fri, 21 Apr 2023 08:29:11 +0200 Date: Fri, 21 Apr 2023 08:29:10 +0200 From: Johan Hovold To: Tejun Heo Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org, kernel-team@meta.com, Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org Subject: Re: [PATCH 02/22] greybus: Use alloc_ordered_workqueue() to create ordered workqueues Message-ID: References: <20230421025046.4008499-1-tj@kernel.org> <20230421025046.4008499-3-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421025046.4008499-3-tj@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 20, 2023 at 04:50:26PM -1000, Tejun Heo wrote: > BACKGROUND > ========== > > When multiple work items are queued to a workqueue, their execution order > doesn't match the queueing order. They may get executed in any order and > simultaneously. When fully serialized execution - one by one in the queueing > order - is needed, an ordered workqueue should be used which can be created > with alloc_ordered_workqueue(). > This patch series audits all callsites that create an UNBOUND workqueue w/ > @max_active==1 and converts them to alloc_ordered_workqueue() as necessary. > > WHAT TO LOOK FOR > ================ > > The conversions are from > > alloc_workqueue(WQ_UNBOUND | flags, 1, args..) > > to > > alloc_ordered_workqueue(flags, args...) > > which don't cause any functional changes. If you know that fully ordered > execution is not ncessary, please let me know. I'll drop the conversion and > instead add a comment noting the fact to reduce confusion while conversion > is in progress. > > If you aren't fully sure, it's completely fine to let the conversion > through. The behavior will stay exactly the same and we can always > reconsider later. > > As there are follow-up workqueue core changes, I'd really appreciate if the > patch can be routed through the workqueue tree w/ your acks. Thanks. > > Signed-off-by: Tejun Heo > Cc: Johan Hovold > Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: greybus-dev@lists.linaro.org Acked-by: Johan Hovold