From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC410C7618E for ; Fri, 21 Apr 2023 16:23:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233017AbjDUQXz (ORCPT ); Fri, 21 Apr 2023 12:23:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232628AbjDUQXx (ORCPT ); Fri, 21 Apr 2023 12:23:53 -0400 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD0297A89; Fri, 21 Apr 2023 09:23:52 -0700 (PDT) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1pptXs-0001nT-1K; Fri, 21 Apr 2023 18:23:36 +0200 Date: Fri, 21 Apr 2023 17:23:29 +0100 From: Daniel Golle To: arinc9.unal@gmail.com Cc: Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Richard van Schagen , Richard van Schagen , Frank Wunderlich , erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [RFC PATCH net-next 02/22] net: dsa: mt7530: use p5_interface_select as data type for p5_intf_sel Message-ID: References: <20230421143648.87889-1-arinc.unal@arinc9.com> <20230421143648.87889-3-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230421143648.87889-3-arinc.unal@arinc9.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2023 at 05:36:28PM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL > > Use the p5_interface_select enumeration as the data type for the > p5_intf_sel field. This ensures p5_intf_sel can only take the values > defined in the p5_interface_select enumeration. > > Signed-off-by: Arınç ÜNAL > --- > drivers/net/dsa/mt7530.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h > index 845f5dd16d83..703f8a528317 100644 > --- a/drivers/net/dsa/mt7530.h > +++ b/drivers/net/dsa/mt7530.h > @@ -674,13 +674,13 @@ struct mt7530_port { > }; > > /* Port 5 interface select definitions */ > -enum p5_interface_select { > - P5_DISABLED = 0, > +typedef enum { We usually avoid adding typedef in kernel code. If the purpose is just to be more verbose in the struct definition, you can as well also just use 'enum p5_interface_select as type in the struct. > + P5_DISABLED, > P5_INTF_SEL_PHY_P0, > P5_INTF_SEL_PHY_P4, > P5_INTF_SEL_GMAC5, > P5_INTF_SEL_GMAC5_SGMII, > -}; > +} p5_interface_select; > > struct mt7530_priv; > > @@ -768,7 +768,7 @@ struct mt7530_priv { > bool mcm; > phy_interface_t p6_interface; > phy_interface_t p5_interface; > - unsigned int p5_intf_sel; > + p5_interface_select p5_intf_sel; enum p5_interface_select p5_intf_sel; > u8 mirror_rx; > u8 mirror_tx; > struct mt7530_port ports[MT7530_NUM_PORTS]; > -- > 2.37.2 >